You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/07/19 00:29:07 UTC
Review Request 23695: Allowed LoadGeneratorFramework to read password from a
file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23695/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-1590
https://issues.apache.org/jira/browse/MESOS-1590
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/examples/load_generator_framework.cpp f74ebce9f33c924832841eb5bac1fb33a289169e
Diff: https://reviews.apache.org/r/23695/diff/
Testing
-------
Ran the program and had it read a password file.
Thanks,
Jiang Yan Xu
Re: Review Request 23695: Allowed LoadGeneratorFramework to read password
from a file.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23695/#review48278
-----------------------------------------------------------
Ship it!
src/examples/load_generator_framework.cpp
<https://reviews.apache.org/r/23695/#comment84684>
it seems a bit weird to do this here.
why not set secret to flags.secret() in an else statement above? that seems more clear.
- Vinod Kone
On July 18, 2014, 10:29 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23695/
> -----------------------------------------------------------
>
> (Updated July 18, 2014, 10:29 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1590
> https://issues.apache.org/jira/browse/MESOS-1590
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/examples/load_generator_framework.cpp f74ebce9f33c924832841eb5bac1fb33a289169e
>
> Diff: https://reviews.apache.org/r/23695/diff/
>
>
> Testing
> -------
>
> Ran the program and had it read a password file.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 23695: Allowed LoadGeneratorFramework to read password
from a file.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23695/#review48508
-----------------------------------------------------------
Bad patch!
Reviews applied: [23695]
Failed command: git apply --index 23695.patch
Error:
error: patch failed: src/examples/load_generator_framework.cpp:27
error: src/examples/load_generator_framework.cpp: patch does not apply
- Mesos ReviewBot
On July 18, 2014, 10:29 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23695/
> -----------------------------------------------------------
>
> (Updated July 18, 2014, 10:29 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1590
> https://issues.apache.org/jira/browse/MESOS-1590
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/examples/load_generator_framework.cpp f74ebce9f33c924832841eb5bac1fb33a289169e
>
> Diff: https://reviews.apache.org/r/23695/diff/
>
>
> Testing
> -------
>
> Ran the program and had it read a password file.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 23695: Allowed LoadGeneratorFramework to read password
from a file.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23695/
-----------------------------------------------------------
(Updated July 25, 2014, 11:47 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Vinod's. NNRF.
Bugs: MESOS-1590
https://issues.apache.org/jira/browse/MESOS-1590
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/examples/load_generator_framework.cpp 13ac8776551acdb0e1b58a69a1011662d0942c0e
Diff: https://reviews.apache.org/r/23695/diff/
Testing
-------
Ran the program and had it read a password file.
Thanks,
Jiang Yan Xu