You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2023/10/13 10:36:47 UTC
[PR] MINOR: WIP [Python][CI] Enable -W error on all Python tests [arrow]
raulcd opened a new pull request, #38259:
URL: https://github.com/apache/arrow/pull/38259
This is just a testing PR related to: https://github.com/apache/arrow/pull/38238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: WIP [Python][CI] Enable -W error on all Python tests [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #38259:
URL: https://github.com/apache/arrow/pull/38259#issuecomment-1761338916
I was expecting the last one to fail 🤔
My expectation was the CLI `-W` was taking precedence but if no input on CLI the `setup.cfg` config should have kicked in, so I was expecting if we don't add the ignore the build to fail 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: WIP [Python][CI] Enable -W error on all Python tests [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #38259:
URL: https://github.com/apache/arrow/pull/38259#issuecomment-1761344012
I assume it doesn't see the setup.cfg, because we run the installed tests, not in-place (using `--pyargs pyarrow`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: WIP [Python][CI] Enable -W error on all Python tests [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd closed pull request #38259: MINOR: WIP [Python][CI] Enable -W error on all Python tests
URL: https://github.com/apache/arrow/pull/38259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: WIP [Python][CI] Enable -W error on all Python tests [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #38259:
URL: https://github.com/apache/arrow/pull/38259#issuecomment-1761342513
Hmm, yeah, that's also my expectation ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: WIP [Python][CI] Enable -W error on all Python tests [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #38259:
URL: https://github.com/apache/arrow/pull/38259#issuecomment-1761318342
Yes, I was pretty sure we would have to add more tweaking for other jobs but to be honest at the moment I am not entirely sure how to fix it the other way, unless we want to add a much broader ignore (without spaces).
There also some builds where we might just want to add `-W ignore` and we basically don't get any error like the nightly builds with numpy/pandas. So probably is worth exploring how much effort this is going to take.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: WIP [Python][CI] Enable -W error on all Python tests [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38259:
URL: https://github.com/apache/arrow/pull/38259#issuecomment-1761299865
Revision: 49f12ed8c2682264f38b8e6b80808cd497c0afd8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0f40117f8a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0f40117f8a)
|Task|Status|
|----|------|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/6507203344/job/17674151129)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: WIP [Python][CI] Enable -W error on all Python tests [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38259:
URL: https://github.com/apache/arrow/pull/38259#issuecomment-1761322948
Revision: 2bdb73512e6d3b5cf1f30fa95f5bb8593a8d9531
Submitted crossbow builds: [ursacomputing/crossbow @ actions-257d34b315](https://github.com/ursacomputing/crossbow/branches/all?query=actions-257d34b315)
|Task|Status|
|----|------|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/6507357794/job/17674622541)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: WIP [Python][CI] Enable -W error on all Python tests [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #38259:
URL: https://github.com/apache/arrow/pull/38259#issuecomment-1761330850
> There also some builds where we might just want to add `-W ignore`
Ah, indeed, we could override those settings on certain builds like that (although we don't want to ignore them, but always show them, so `-W always`?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: WIP [Python][CI] Enable -W error on all Python tests [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #38259:
URL: https://github.com/apache/arrow/pull/38259#issuecomment-1761309409
I thought about that yesterday as well, but this won't work without adding some more ignore filters. For example on the nightly builds with numpy/pandas we still have some deprecation warnings.
The annoying part with this way is that we can't tweak it per build like with the env var, but of course we can then just add enough filters to cover all builds, and don't care that they are too broad for some other builds. And in any case, this solves the whole issue of not being able to pass it through an env var if the filter has spaces as we have in https://github.com/apache/arrow/pull/38238. And another benefit is that this then also is used when running the tests locally, making it more consistent with CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: WIP [Python][CI] Enable -W error on all Python tests [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #38259:
URL: https://github.com/apache/arrow/pull/38259#issuecomment-1761345523
Short term, while we figure this out, maybe we can just remove the "-W error" for now in https://github.com/apache/arrow/pull/38238 so that the nightly CI is green again. And then we can do a follow-up PR like this one to figure it out in a more robust way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: WIP [Python][CI] Enable -W error on all Python tests [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #38259:
URL: https://github.com/apache/arrow/pull/38259#issuecomment-1761319683
@github-actions crossbow submit test-conda-python-3.11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: WIP [Python][CI] Enable -W error on all Python tests [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #38259:
URL: https://github.com/apache/arrow/pull/38259#issuecomment-1761296453
@github-actions crossbow submit test-conda-python-3.11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org