You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Jan Hentschel <ja...@ultratendency.com> on 2017/03/15 18:41:12 UTC
Review Request 57657: SENTRY-1658: Fixed possible null pointer
dereference in SentryShellHive
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57657/
-----------------------------------------------------------
Review request for sentry.
Bugs: SENTRY-1658
https://issues.apache.org/jira/browse/SENTRY-1658
Repository: sentry
Description
-------
Fixed a possible null pointer dereference in **SentryShellHive**.
Diffs
-----
sentry-service/sentry-service-client/src/main/java/org/apache/sentry/provider/db/tools/SentryShellHive.java dc7f829
Diff: https://reviews.apache.org/r/57657/diff/1/
Testing
-------
Successful run of **mvn clean install**.
Thanks,
Jan Hentschel
Re: Review Request 57657: SENTRY-1658: Fixed possible null pointer
dereference in SentryShellHive
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57657/#review169046
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On March 15, 2017, 6:41 p.m., Jan Hentschel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57657/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 6:41 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1658
> https://issues.apache.org/jira/browse/SENTRY-1658
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Fixed a possible null pointer dereference in **SentryShellHive**.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-client/src/main/java/org/apache/sentry/provider/db/tools/SentryShellHive.java dc7f829
>
>
> Diff: https://reviews.apache.org/r/57657/diff/1/
>
>
> Testing
> -------
>
> Successful run of **mvn clean install**.
>
>
> Thanks,
>
> Jan Hentschel
>
>
Re: Review Request 57657: SENTRY-1658: Fixed possible null pointer
dereference in SentryShellHive
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On March 15, 2017, 7:07 p.m., Alexander Kolbasov wrote:
> > Please fix the commit message
>
> Jan Hentschel wrote:
> What is wrong with the commit message?
The commit message should be
SENTRY-1658: Null pointer derefeence in SentryShellHive
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57657/#review169047
-----------------------------------------------------------
On March 15, 2017, 6:41 p.m., Jan Hentschel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57657/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 6:41 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1658
> https://issues.apache.org/jira/browse/SENTRY-1658
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Fixed a possible null pointer dereference in **SentryShellHive**.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-client/src/main/java/org/apache/sentry/provider/db/tools/SentryShellHive.java dc7f829
>
>
> Diff: https://reviews.apache.org/r/57657/diff/1/
>
>
> Testing
> -------
>
> Successful run of **mvn clean install**.
>
>
> Thanks,
>
> Jan Hentschel
>
>
Re: Review Request 57657: SENTRY-1658: Fixed possible null pointer
dereference in SentryShellHive
Posted by Jan Hentschel <ja...@ultratendency.com>.
> On March 15, 2017, 8:07 p.m., Alexander Kolbasov wrote:
> > Please fix the commit message
What is wrong with the commit message?
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57657/#review169047
-----------------------------------------------------------
On March 15, 2017, 7:41 p.m., Jan Hentschel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57657/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 7:41 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1658
> https://issues.apache.org/jira/browse/SENTRY-1658
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Fixed a possible null pointer dereference in **SentryShellHive**.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-client/src/main/java/org/apache/sentry/provider/db/tools/SentryShellHive.java dc7f829
>
>
> Diff: https://reviews.apache.org/r/57657/diff/1/
>
>
> Testing
> -------
>
> Successful run of **mvn clean install**.
>
>
> Thanks,
>
> Jan Hentschel
>
>
Re: Review Request 57657: SENTRY-1658: Fixed possible null pointer
dereference in SentryShellHive
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57657/#review169047
-----------------------------------------------------------
Ship it!
Please fix the commit message
- Alexander Kolbasov
On March 15, 2017, 6:41 p.m., Jan Hentschel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57657/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 6:41 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1658
> https://issues.apache.org/jira/browse/SENTRY-1658
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Fixed a possible null pointer dereference in **SentryShellHive**.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-client/src/main/java/org/apache/sentry/provider/db/tools/SentryShellHive.java dc7f829
>
>
> Diff: https://reviews.apache.org/r/57657/diff/1/
>
>
> Testing
> -------
>
> Successful run of **mvn clean install**.
>
>
> Thanks,
>
> Jan Hentschel
>
>
Re: Review Request 57657: SENTRY-1658: Fixed possible null pointer
dereference in SentryShellHive
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57657/#review169082
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On March 15, 2017, 6:41 p.m., Jan Hentschel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57657/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 6:41 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1658
> https://issues.apache.org/jira/browse/SENTRY-1658
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Fixed a possible null pointer dereference in **SentryShellHive**.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-client/src/main/java/org/apache/sentry/provider/db/tools/SentryShellHive.java dc7f829
>
>
> Diff: https://reviews.apache.org/r/57657/diff/1/
>
>
> Testing
> -------
>
> Successful run of **mvn clean install**.
>
>
> Thanks,
>
> Jan Hentschel
>
>