Re: [PR] chore: Improve the code style by introducing macros [kvrocks]

["PragmaTwice (via GitHub)" <gi...@apache.org>]

PragmaTwice commented on code in PR #2629:
URL: https://github.com/apache/kvrocks/pull/2629#discussion_r1828611704


##########
src/common/status.h:
##########
@@ -397,3 +397,16 @@ bool StatusIsOK(const T& v) {
     if (!StatusIsOK(status)) return std::forward<decltype(status)>(status); \
     std::forward<decltype(status)>(status);                                 \
   }))
+
+// NOLINTNEXTLINE
+#define RETURN_IF_ERROR(...)                                                \

Review Comment:
   Hmmm I don't think you've got my point. As I've said, this macro is useless and can be replaced by GET_OR_RET. Actually it's function is a subset of GET_OR_RET.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org