You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergio Pena <se...@cloudera.com> on 2017/08/07 13:59:11 UTC
Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles
by sending them from ptest-client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60085/#review182270
-----------------------------------------------------------
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
Lines 120 (patched)
<https://reviews.apache.org/r/60085/#comment258171>
is there another wayt to get the file instead of the system environment variables?
How do we get the cloud execution properties file?
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/Context.java
Lines 266 (patched)
<https://reviews.apache.org/r/60085/#comment258170>
Can you add javadoc to all the new public methods and ContextBuilder?
- Sergio Pena
On July 31, 2017, 8:05 a.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60085/
> -----------------------------------------------------------
>
> (Updated July 31, 2017, 8:05 a.m.)
>
>
> Review request for hive, Marta Kuczora, Peter Vary, and Sergio Pena.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client
>
>
> Diffs
> -----
>
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java 2f96ad03023e9f51d44d203f34edd04183605a22
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/Context.java 14984bafdd18fb7636e729cc7fbbfa349b0f043e
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/ExecutionContextConfiguration.java 35ddd44accf34be1f5957c6df31802ee8c8022b5
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java e584f9c105fa134e3e267d6c6817d441b4c6b249
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java a243774e52f3f5fda4a082bb99387cf5808c307b
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java b97b890dfe855539de2696788327ba9b4a841ff3
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestContext.java PRE-CREATION
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java 848faf27af1ed8945d7013b6562bab544605e4bc
>
>
> Diff: https://reviews.apache.org/r/60085/diff/3/
>
>
> Testing
> -------
>
> Added unit tests for the Context class.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>