[jira] [Commented] (NIFI-3141) TailFile failed with ArrayIndexOutOfBoundsException after updating NiFi to 1.1.0

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713831#comment-15713831 ] 

ASF GitHub Bot commented on NIFI-3141:
--------------------------------------

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/1289

    NIFI-3141: Fixed TailFile ArrayIndexOutOfBounds.

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    
    - Added unit test cases to simulate NiFi version update which fails without this fix.
    - Added state object migration code, add file.0. prefix to state keys,
      and add length from stored position.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-3141

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1289
    
----
commit 28676fdb95af98cca5d30f3ce37af6f5ace7a19a
Author: Koji Kawamura <ij...@apache.org>
Date:   2016-12-02T02:23:33Z

    NIFI-3141: Fixed TailFile ArrayIndexOutOfBounds.
    
    - Added unit test cases to simulate NiFi version update which fails without this fix.
    - Added state object migration code, add file.0. prefix to state keys,
      and add length from stored position.

----


> TailFile failed with ArrayIndexOutOfBoundsException after updating NiFi to 1.1.0
> --------------------------------------------------------------------------------
>
>                 Key: NIFI-3141
>                 URL: https://issues.apache.org/jira/browse/NIFI-3141
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Koji Kawamura
>         Attachments: NiFi 1.0.0 TailFile status.png, NiFi 1.1.0 TailFile status.png
>
>
> TailFile with NiFi 1.0.0 or earlier only handles single file. So it doesn't have index in state key name. But the updated TailFile expects stored state key has index in it, tried to extract the index and failed.
> {code}
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 1
>         at org.apache.nifi.processors.standard.TailFile.initStates(TailFile.java:365) ~[na:na]
>         at org.apache.nifi.processors.standard.TailFile.recoverState(TailFile.java:348) ~[na:na]
>         ... 16 common frames omitted
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)