You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/18 09:13:56 UTC

[GitHub] [airflow] RosterIn commented on a change in pull request #13536: Fix string encoding in DockerOperator when using xcom / json

RosterIn commented on a change in pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#discussion_r578249723



##########
File path: airflow/providers/docker/ADDITIONAL_INFO.md
##########
@@ -23,3 +23,7 @@
 
   * `Remove failed DockerOperator tasks with auto_remove=True (#13532) (#13993)`
   * `Fix error on DockerSwarmOperator with auto_remove True (#13532) (#13852)`
+### Changes to XCom return values
+
+* the return value of XCom is of type `str` (as opposed to `bytes`)
+* if `xcom_all` is set to `False` only the last line of the log (separated by `\n`) will be included in the XCom value

Review comment:
       ```suggestion
   * if `xcom_all` is set to `False` only the last line of the log (separated by `\n`) will be included in the XCom value
   
   ```
   add new line at end of file to make test green




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org