You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2015/12/03 17:43:49 UTC

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-982: valuesDecr, valu...

GitHub user okram opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/169

    TINKERPOP3-982: valuesDecr, valuesIncr, keysDecr, and valuesDecr is lame.

    https://issues.apache.org/jira/browse/TINKERPOP3-982
    
    I made it so the `Column` enum implements `Function<Object,Object>` and where `Column.keys` and `Column.values` project out the respective "column" for `Map`, `Map.Entry`, `Path`, etc. What is cool about this is that now we no longer need `SelectColumnStep` -- `select(keys) == map(keys)`. Of course, like `where(traversal) == filter(traversal)`, I left `select(column)` in `GraphTraversal` and don't plan to remove it. 
    
    Given that this is a minor version push (3.1.1), I will NOT deprecate `Order.valueDecr`/etc. until 3.2.0 and have the following ticket to remind me.  https://issues.apache.org/jira/browse/TINKERPOP-1021
    
    Finally, `mvn clean install` and a full `publish-docs.sh` are happy happy long time.
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-982

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/169.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #169
    
----
commit 8771ee5f58c7ec133cfb50987fe91b862fb9ad14
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2015-11-24T22:04:02Z

    Column enum now implements Function. SelectColumnStep goes away as now select(column) is simply  (un(ddadhe covers) map(column) -- bam. Order.valueDecr/etc. goes away in favor of order().by(values,decr). This means we have decoupled the selector from the comparator so people can do other things besides decr and incr on values.

commit 0bda36c74edaf93fef3585f09c31b05e4f46c908
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2015-11-30T19:45:53Z

    this is a breaking push. need to get Groovy GremlinLoader happy about comparator. Will get back to this.

commit 8d04c825c74933155a6b651edb413e37b30bd970
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2015-12-03T16:42:27Z

    added more docs to Order Step around Columm.keys and Column.values. Added a GraphTraversal.by() safeguard to ensure no ambiguous method call issues.

commit 8662fcb8eb24329da99908cff0194c1d81bbefae
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2015-12-03T16:42:34Z

    Merge branch 'master' into TINKERPOP3-982

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-982: valuesDecr, valu...

Posted by okram <gi...@git.apache.org>.
Github user okram closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/169


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-982: valuesDecr, valu...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/169#issuecomment-161767740
  
    This was merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-982: valuesDecr, valu...

Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/169#issuecomment-161741357
  
    Nice one.
    
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-982: valuesDecr, valu...

Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/169#issuecomment-161725919
  
    Looks good, tests pass.
    
    VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---