[jira] [Commented] (MESOS-335) Statistics.truncate is flaky.

["Benjamin Mahler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594048#comment-13594048 ] 

Benjamin Mahler commented on MESOS-335:
---------------------------------------

They also used a double! https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/quantity/Time.java

I'm debating whether to use a base double value of seconds, or a base int64_t value of nanoseconds. I'm still leaning towards the latter, which can be done without compromising the Duration interface (by exporting doubles, but internally using an int64_t).
                
> Statistics.truncate is flaky.
> -----------------------------
>
>                 Key: MESOS-335
>                 URL: https://issues.apache.org/jira/browse/MESOS-335
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Benjamin Mahler
>            Assignee: Benjamin Mahler
>
> Looks like a double comparison issue..?
> [ RUN      ] Statistics.truncate
> ../../../third_party/libprocess/src/tests/statistics_tests.cpp:58: Failure
> Expected: (Clock::now()) >= (values.get().begin()->first.secs()), actual: 1.36184e+09 vs 1.36184e+09
> ../../../third_party/libprocess/src/tests/statistics_tests.cpp:71: Failure
> Expected: (Clock::now()) >= (values.get().begin()->first.secs()), actual: 1.36193e+09 vs 1.36193e+09
> [  FAILED  ] Statistics.truncate (1 ms)
> Another flaky one:
> [ RUN      ] Statistics.archive
> ../../../third_party/libprocess/src/tests/statistics_tests.cpp:175: Failure
> Value of: values.get().empty()
>   Actual: false
> Expected: true
> [  FAILED  ] Statistics.archive (2 ms)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira