[GitHub] incubator-weex pull request #1261: [WEEX-456][iOS]try to fix bas_access of p...

[lucky-chen <gi...@git.apache.org>]

GitHub user lucky-chen opened a pull request:

    https://github.com/apache/incubator-weex/pull/1261

    [WEEX-456][iOS]try to fix bas_access of parentNode

    - set `node->parent=null` when remove node
    - `removeFixedComponent` should be called before `delete node`
    - `removeNode` should called in componentThread

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lucky-chen/incubator-weex ios-bugfix-nodeparent

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1261
    
----
commit d5e83d573c516c13512ef7611aeb0e4597358d6a
Author: zhongcang <qh...@...>
Date:   2018-06-13T07:35:08Z

    [WEEX-456][ios]try to fix bas_access of parentNode

----


---

[GitHub] incubator-weex issue #1261: [WEEX-456][iOS]try to fix bas_access of parentNo...

[weex-bot <gi...@git.apache.org>]

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1261
  
    
    <!--
      0 failure: 
      0 warning: 
      2 messages
      
    -->
    
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>has no jsfm file changed.</td>
        </tr>
      
    <tr>
          <td>:book:</td>
          <td>jsfm test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---

[GitHub] incubator-weex pull request #1261: [WEEX-456][iOS]try to fix bas_access of p...

[lucky-chen <gi...@git.apache.org>]

Github user lucky-chen closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1261


---