You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/02 20:09:56 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request #2417: (Re)enable building netbeans offline
matthiasblaesing opened a new pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417
This PR reestablishes the possibility to build netbeans offline. Offline in this case means, that thirdparty dependencies can be downloaded once and after that is done, the build can be done without a network connection.
This is the sequence:
0. Change into the netbeans source directory
1. Download release properties: `wget -O ../netbeansrelease.json "https://gitbox.apache.org/repos/asf?p=netbeans-jenkins-lib.git;a=blob_plain;f=meta/netbeansrelease.json"`
2. Download external binaries: `ant download-all-extbins`
3. Run the build: `ant -Dmetabuild.jsonurl=file:../netbeansrelease.json`
Steps 1+2 need an internet connection, step 3 can be run offline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2417: (Re)enable building netbeans offline
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-702938757
The intention of this PR is to ensure netbeans can be build without requiring a constant connection.
@ehsavoie: The javaee parts were problematic because some of the XSDs imported external XSDs from internet servers. In all cases either the requires XSDs were already in the source base and just needed to be moved to the right place or absolute URLs had to replaced with relative paths.
@lkishalmi Another problem was the building of the gradle tooling - I tested building it with the "--offline" option and that works. Do you see a problem here?
@jtulach is this what you meant in your email? Could you please give it a spin?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #2417: (Re)enable building netbeans offline
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2417: (Re)enable building netbeans offline
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-703797731
Thank you for the review. Let's get this in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2417: (Re)enable building netbeans offline
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-703053828
```--offline``` should be fine as far as I could check. Once the external binaries are downloaded everything would be locally resolvable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2417: (Re)enable building netbeans offline
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-703712606
@neilcsmith-net @ebarboni my target was enabling build offline - the procedure was just to show, that it can be successfully done, without to much fuzz. You can broaden the scope, but it was not intended to be.
The approach to download the json file to some "build" directory will not work. `ant clean` will clean the build directory and your offline buildability is gone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni edited a comment on pull request #2417: (Re)enable building netbeans offline
Posted by GitBox <gi...@apache.org>.
ebarboni edited a comment on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-703571876
Hi @matthiasblaesing
maybe we could add a step to download-all-extbins to download the json file in correct place to avoid the wget phase.
AFAIK download-all-extbins is not used in "standard build".
It make me think that step 3 -D parameters is a hack as json file should be detected and used.
Maybe the following code on build.xml in nbbuild line 112 can avoid all the json mess.
```
<!-- get all json info we have on apache gitbox -->
<property name="metabuild.releasejson" value="${nb_all}/nbbuild/build/netbeansrelease.json"/>
<condition property="metabuild.jsonurl" value="https://gitbox.apache.org/repos/asf?p=netbeans-jenkins-lib.git;a=blob_plain;f=meta/netbeansrelease.json">
<not>
<isset property="metabuild.jsonurl"/>
</not>
</condition>
<condition property="needjson">
<not>
<available file="${metabuild.releasejson}" />
</not>
</condition>
<sequential if:set="needjson" >
<configureproxy connectTo="${metabuild.jsonurl}" hostProperty="proxyHost" portProperty="proxyPort"/>
<setproxy proxyhost="${proxyHost}" proxyPort="${proxyPort}"/>
<get dest="${metabuild.releasejson}" skipexisting="false" src="${metabuild.jsonurl}" />
</sequential>
<!-- read info from gitinfo.properties , if present in source bundle copy gitinfo-->
```
EDIT to add the xml code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2417: (Re)enable building netbeans offline
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-705485787
Today I updated to most recent master and my build succeeded (instead of failing in `javaee.wildfly` module). Very nice surprise. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net removed a comment on pull request #2417: (Re)enable building netbeans offline
Posted by GitBox <gi...@apache.org>.
neilcsmith-net removed a comment on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-703753091
> The approach to download the json file to some "build" directory will not work. ant clean will clean the build directory and your offline buildability is gone.
@matthiasblaesing I actually said `nbbuild/` not `nbbuild/build/`. Check the source zip releases - they have two extra files in there - `gitinfo.properties` and `netbeansrelease.properties` to ensure consistent builds. Copying those from `nbbuild/build/` to `nbbuild/` should allow this to work offline (and if it doesn't that's a bug I think).
Agree with @ebarboni this is OK to merge, but do think we should look at using the above mechanism (or extension of it) in a latter PR, in place of your instructions here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2417: (Re)enable building netbeans offline
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-705485787
Today I updated to most recent master and my build succeeded (instead of failing in `javaee.wildfly` module). Very nice surprise. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2417: (Re)enable building netbeans offline
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-703736793
For me this is ok to merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2417: (Re)enable building netbeans offline
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-703753091
> The approach to download the json file to some "build" directory will not work. ant clean will clean the build directory and your offline buildability is gone.
@matthiasblaesing I actually said `nbbuild/` not `nbbuild/build/`. Check the source zip releases - they have two extra files in there - `gitinfo.properties` and `netbeansrelease.properties` to ensure consistent builds. Copying those from `nbbuild/build/` to `nbbuild/` should allow this to work offline (and if it doesn't that's a bug I think).
Agree with @ebarboni this is OK to merge, but do think we should look at using the above mechanism (or extension of it) in a latter PR, in place of your instructions here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #2417: (Re)enable building netbeans offline
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-703543983
Requested review from Eric. I'm dubious about the instructions. Would have thought mirroring how the source release handles this might be better? eg. netbeansrelease.properties in nbbuild/ If existence of that file doesn't stop request for the release json (haven't checked that yet) that sounds like an error that needs fixing anyway?!
EDIT : removed -1 because it's the instructions in the description, not the commits, that may need addressing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2417: (Re)enable building netbeans offline
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-703571876
Hi @matthiasblaesing
maybe we could add a step to download-all-extbins to download the json file in correct place to avoid the wget phase.
AFAIK download-all-extbins is not used in "standard build".
It make me think that step 3 -D parameters is a hack as json file should be detected and used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2417: (Re)enable building netbeans offline
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-703543983
-1 until review from Eric. I'm dubious about this way of doing it. Would have thought mirroring how the source release handles this might be better? eg. netbeansrelease.properties in nbbuild/ If existence of that file doesn't stop request for the release json (haven't checked that yet) that sounds like an error that needs fixing anyway?!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists