You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "jeantil (via GitHub)" <gi...@apache.org> on 2025/08/12 17:16:40 UTC

[PR] Remote build cache [james-project]

jeantil opened a new pull request, #2785:
URL: https://github.com/apache/james-project/pull/2785

   This PR configures the remote build cache for james now that infra has setup the cache node, it also cleans up a build warning because of duplicated lib declarations ( see specific commit )
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [INFRA-25461] Remote build cache [james-project]

Posted by "jeantil (via GitHub)" <gi...@apache.org>.
jeantil commented on code in PR #2785:
URL: https://github.com/apache/james-project/pull/2785#discussion_r2278375524


##########
pom.xml:
##########
@@ -4112,25 +4051,21 @@
                             </configuration>
                         </plugin>
                         <plugin>
-                            <groupId>net.alchim31.maven</groupId>
-                            <artifactId>scala-maven-plugin</artifactId>
+                            <groupId>com.github.ekryd.sortpom</groupId>
+                            <artifactId>sortpom-maven-plugin</artifactId>
                             <executions>
                                 <execution>
-                                    <id>scala-compile-first</id>
-                                    <phase>none</phase>
-                                </execution>
-                                <execution>
-                                    <id>scala-test-compile</id>
+                                    <id>strict-pom-ordering</id>
                                     <phase>none</phase>
                                 </execution>
                             </executions>
                         </plugin>
                         <plugin>
-                            <groupId>com.github.ekryd.sortpom</groupId>
-                            <artifactId>sortpom-maven-plugin</artifactId>
+                            <groupId>io.github.evis</groupId>
+                            <artifactId>scalafix-maven-plugin_2.13</artifactId>

Review Comment:
   we do not need to rerun scalafix (which is not cached) on the stable tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [INFRA-25461] Remote build cache [james-project]

Posted by "jeantil (via GitHub)" <gi...@apache.org>.
jeantil commented on PR #2785:
URL: https://github.com/apache/james-project/pull/2785#issuecomment-3190710065

   build 12 success,  the [build scan](https://develocity.apache.org/s/7z45cnk2pse5a/performance/execution) confirms the 5hxx of tests are cacheable. Stable test lasted 5h39 which is the worst case and will only trigger when changing somehting that requires rerruning all tests
   build 13 success ([build scan](https://develocity.apache.org/s/7y22vlkhwudju)), Stable test lasted 22minutes ! saving a bit over 5h for the best case scenario : everything from cache.
   
   These results will be further improved by making 2 goals cacheable: 
   - scala compile 
   - jacoco aggregate test report 
   
   I have a POC for scala compile but I don't think its mergeable as is, I had to exclude some properties from the cache key computation that I would rather to make sure we invalidate the cache if they change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [INFRA-25461] Remote build cache [james-project]

Posted by "jeantil (via GitHub)" <gi...@apache.org>.
jeantil commented on code in PR #2785:
URL: https://github.com/apache/james-project/pull/2785#discussion_r2274822952


##########
Jenkinsfile:
##########
@@ -96,7 +96,7 @@ pipeline {
         stage('Stable Tests') {
             steps {
                 echo 'Running tests'
-                sh 'mvn -B -e -fae test ${MVN_SHOW_TIMESTAMPS} -P ci-test ${MVN_LOCAL_REPO_OPT} -Dassembly.skipAssembly=true jacoco:report-aggregate@jacoco-report'
+                sh 'mvn -B -e -fae clean test ${MVN_SHOW_TIMESTAMPS} -P ci-test ${MVN_LOCAL_REPO_OPT} -Dassembly.skipAssembly=true jacoco:report-aggregate@jacoco-report'

Review Comment:
   clean is required for storing results in the build cache 
   the remote build cache will ensure we don't spend to much rebuilding already built stuff
   
   anyway build time is negligible compared to test runtime so event with suboptimal caching we should benefit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [INFRA-25461] Remote build cache [james-project]

Posted by "jeantil (via GitHub)" <gi...@apache.org>.
jeantil merged PR #2785:
URL: https://github.com/apache/james-project/pull/2785


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [INFRA-25461] Remote build cache [james-project]

Posted by "jeantil (via GitHub)" <gi...@apache.org>.
jeantil commented on code in PR #2785:
URL: https://github.com/apache/james-project/pull/2785#discussion_r2275455570


##########
Jenkinsfile:
##########
@@ -89,14 +89,14 @@ pipeline {
         stage('Build') {
             steps {
                 echo 'Building'
-                sh 'mvn -U -B -e clean install -DskipTests -Djib.skip -T1C ${MVN_SHOW_TIMESTAMPS} ${MVN_LOCAL_REPO_OPT}'
+                sh 'mvn -U -B -e clean install -DskipTests -Djib.skip  -DrerunGoals -T1C ${MVN_SHOW_TIMESTAMPS} ${MVN_LOCAL_REPO_OPT}'

Review Comment:
   to be removed as I seem to have polluted the cache with bad outputs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [INFRA-25461] Remote build cache [james-project]

Posted by "jeantil (via GitHub)" <gi...@apache.org>.
jeantil commented on code in PR #2785:
URL: https://github.com/apache/james-project/pull/2785#discussion_r2270607922


##########
.mvn/develocity.xml:
##########
@@ -50,7 +50,8 @@
       </cleanup>
     </local>
     <remote>
-      <storeEnabled>false</storeEnabled>
+      <enabled>true</enabled>

Review Comment:
   everyone can download built artifacts, but only the CI is allowed to store them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [INFRA-25461] Remote build cache [james-project]

Posted by "jeantil (via GitHub)" <gi...@apache.org>.
jeantil commented on code in PR #2785:
URL: https://github.com/apache/james-project/pull/2785#discussion_r2278374993


##########
pom.xml:
##########
@@ -4041,69 +4043,6 @@
                                 </execution>
                             </executions>
                         </plugin>
-                        <plugin>

Review Comment:
   we need these goals to be included since the cache requires the clean goal but including them is painless because the cache takes care of most of the cost



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org