You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "tbonelee (via GitHub)" <gi...@apache.org> on 2024/08/25 11:06:52 UTC

[PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

tbonelee opened a new pull request, #4802:
URL: https://github.com/apache/zeppelin/pull/4802

   ### What is this PR for?
   
   For several years, Zeppelin has supported both the old and new UIs, with the old UI remaining as the default.
   However, as the new UI offers a more modern design, I believe it might be beneficial to consider making it the default interface.
   
   #### Rationale
   The new UI presents a more contemporary user experience, which could align better with users' expectations today.
   Transitioning to the new UI as the default may help in keeping Zeppelin more up-to-date and user-friendly.
   Of course, I am aware that this change might impact various parts of the project, so I propose we carefully review this before proceeding.
   
   ### What type of PR is it?
   Improvement
   
   ### Todos
   * [x] - Update all references to the web app context paths.
   
   ### What is the Jira issue?
   * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/6064
   
   ### How should this be tested?
   - Verify that the new UI is accessible via root path.
   - Ensure the old UI can still be accessed via `/classic`.
   
   ### Questions:
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No, but it may affect users' accustomed access paths.
   * Does this needs documentation? Maybe it would be helpful to provide guidance on how users could access the old UI under the new path, especially for those accustomed to the previous default. However, I'm not entirely sure if this is the best approach, so I haven't added any documentation for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2313013459

   Additionally, I made the following changes:
   1. Added the `web-classic` profile, removed the `web-angular` profile, and changed the default UI included during the build to the new UI (formerly included in `web-angular` profile).
   2. Renamed configuration variable names:
      - `zeppelin.war` -> `zeppelin.classic.war`
      - `zeppelin.angular.war` -> `zeppelin.war`
   3. Renamed module names:
      - `zeppelin-web` -> `zeppelin-web-classic`
      - `zeppelin-web-angular` -> `zeppelin-web`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2315931070

   After rebasing, I updated the URLs for the Selenium tests, and I also updated the test URLs in `DirAccessTest`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on code in PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#discussion_r1730832772


##########
zeppelin-web/src/components/navbar/navbar.html:
##########
@@ -106,7 +106,7 @@
               <li ng-if="ticket.principal && ticket.principal !== 'anonymous'" role="separator" style="margin: 5px 0;" class="divider"></li>
               <li ng-if="ticket.principal && ticket.principal !== 'anonymous'"><a ng-click="navbar.logout()">Logout</a></li>
               <li role="separator" style="margin: 5px 0;" class="divider"></li>
-              <li><a href="/next">Try the new Zeppelin</a></li>
+              <li><a href="/">Try the new Zeppelin</a></li>

Review Comment:
   A different wording should be used at this point.



##########
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java:
##########
@@ -226,8 +226,8 @@ protected void configure() {
         });
 
     // Multiple Web UI
-    final WebAppContext defaultWebApp = setupWebAppContext(contexts, zConf, zConf.getString(ConfVars.ZEPPELIN_WAR), zConf.getServerContextPath());
-    final WebAppContext nextWebApp = setupWebAppContext(contexts, zConf, zConf.getString(ConfVars.ZEPPELIN_ANGULAR_WAR), WEB_APP_CONTEXT_NEXT);
+    final WebAppContext defaultWebApp = setupWebAppContext(contexts, zConf, zConf.getString(ConfVars.ZEPPELIN_WAR), WEB_APP_CONTEXT_CLASSIC);

Review Comment:
   I think it makes sense to rename the Java variables as well.



##########
zeppelin-web-angular/src/app/share/header/header.component.html:
##########
@@ -67,7 +67,7 @@
           <li nz-menu-item (click)="logout()">Logout</li>
         </ng-container>
         <li nz-menu-divider></li>
-        <li nz-menu-item><a href="/">Old Version</a></li>
+        <li nz-menu-item><a href="/classic">Old Version</a></li>

Review Comment:
   Perhaps “Classic Version” should be used here instead of “Old Version”.
   ```suggestion
           <li nz-menu-item><a href="/classic">Classic Version</a></li>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on code in PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#discussion_r1731279221


##########
zeppelin-web/src/components/navbar/navbar.html:
##########
@@ -106,7 +106,7 @@
               <li ng-if="ticket.principal && ticket.principal !== 'anonymous'" role="separator" style="margin: 5px 0;" class="divider"></li>
               <li ng-if="ticket.principal && ticket.principal !== 'anonymous'"><a ng-click="navbar.logout()">Logout</a></li>
               <li role="separator" style="margin: 5px 0;" class="divider"></li>
-              <li><a href="/next">Try the new Zeppelin</a></li>
+              <li><a href="/">Try the new Zeppelin</a></li>

Review Comment:
   As you mentioned, using the term "Default UI" seems natural.
   How about this phrase: "Switch to the default UI"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2318588226

   The Selenium test passed in my personal repository's GitHub Actions. Therefore I assumed it was a temporary issue and did not make any change.
   I've tried to fix the remaining broken tests. Please review and confirm.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2314344774

   @Reamer 
   I have reverted the commits related to 2. and 3.
   Is there anything else that needs to be reverted?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2314347402

   code changes lgtm, I have not tested it locally though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "kevinjmh (via GitHub)" <gi...@apache.org>.
kevinjmh commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2309145314

   I would like to switch to the new UI too, but tests and bugs fixed should be ahead. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2308785167

   @jongyoul I've made a PR to set the new UI as the default. Please review it when you have some time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2323801946

   Thank you for checking it. By the way, I'm still worried about providing the new UI as a default for the next release but let's see how's going.
   
   I suggest that we provide an option to store the type of UI, which means we should use the same type of UI after we restart the Zeppelin. Could you please add the configuration? Otherwise, could you please create a ticket for it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2323887666

   As Cheng said, I thought we would have a configuration storing the type of UI and the Zeppelin server uses it. But, we don't have that kind of configuration yet so we'd better discuss it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2310263840

   Strongly +1 for making the Angular UI as default even though there are some bugs need to be fixed, and renaming the existing one to "Classic UI".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "kevinjmh (via GitHub)" <gi...@apache.org>.
kevinjmh commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2309148181

   ![image](https://github.com/user-attachments/assets/00d2fe8e-ca11-48e3-8cbf-003c4852e0cc)
   I tried several options above, short-cut does not work, clone only create an empty paragraph without content


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2323842842

   > when someone enters the top-level URL of Zeppelin, they should be redirected to the most recently accessed UI?
   
   Hmm... maybe we just need a configuration to allow the administrator to decide the default UI?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2314552746

   > @jongyoul The current release bundles both classic and new UI, and allows users to switch to each other by clicking a button, the proposed approach "change new UI to default UI" looks straightforward to me, and users still have the option to switch back to the classic UI by just clicking a button if they find bugs in the new UI.
   
   Yes, right. we can switch for now but I think it would be better to change gradually so my idea is to provide a new version with a separate package like zeppelin-bin-new-ui.tgz and so on for the next release. Then, we can check the community's feedback and change the default permanently. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2317509063

   @tbonelee Please check the CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#discussion_r1731291213


##########
zeppelin-web/src/components/navbar/navbar.html:
##########
@@ -106,7 +106,7 @@
               <li ng-if="ticket.principal && ticket.principal !== 'anonymous'" role="separator" style="margin: 5px 0;" class="divider"></li>
               <li ng-if="ticket.principal && ticket.principal !== 'anonymous'"><a ng-click="navbar.logout()">Logout</a></li>
               <li role="separator" style="margin: 5px 0;" class="divider"></li>
-              <li><a href="/next">Try the new Zeppelin</a></li>
+              <li><a href="/">Try the new Zeppelin</a></li>

Review Comment:
   @tbonelee I replied here https://github.com/apache/zeppelin/pull/4802/files#r1731289824



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#discussion_r1731272256


##########
zeppelin-web/src/components/navbar/navbar.html:
##########
@@ -106,7 +106,7 @@
               <li ng-if="ticket.principal && ticket.principal !== 'anonymous'" role="separator" style="margin: 5px 0;" class="divider"></li>
               <li ng-if="ticket.principal && ticket.principal !== 'anonymous'"><a ng-click="navbar.logout()">Logout</a></li>
               <li role="separator" style="margin: 5px 0;" class="divider"></li>
-              <li><a href="/next">Try the new Zeppelin</a></li>
+              <li><a href="/">Try the new Zeppelin</a></li>

Review Comment:
   might be "Classic UI" vs. "Default UI"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2314417264

   The code changes are now much clearer. Please perform a rebase to the current master branch, as there are merge conflicts. Furthermore, I think the Selenium tests for the “Classic” UI need to be adjusted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2314442942

   I have a question. In this PR, will we permanently change the default web to a new one? I intended to release two versions with an old and new UI separately. After releasing 0.12.0 with those manners we can try to change the default UI for the 0.13.0 release in my understanding. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2314468576

   @jongyoul The current release bundles both classic and new UI, and allows users to switch to each other by clicking a button, the proposed approach "switch new UI to default UI" looks straightforward to me, and users still have the option to switch back to the classic UI by just clicking a button if they find bugs in the new UI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on code in PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#discussion_r1731246975


##########
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java:
##########
@@ -226,8 +226,8 @@ protected void configure() {
         });
 
     // Multiple Web UI
-    final WebAppContext defaultWebApp = setupWebAppContext(contexts, zConf, zConf.getString(ConfVars.ZEPPELIN_WAR), zConf.getServerContextPath());
-    final WebAppContext nextWebApp = setupWebAppContext(contexts, zConf, zConf.getString(ConfVars.ZEPPELIN_ANGULAR_WAR), WEB_APP_CONTEXT_NEXT);
+    final WebAppContext defaultWebApp = setupWebAppContext(contexts, zConf, zConf.getString(ConfVars.ZEPPELIN_WAR), WEB_APP_CONTEXT_CLASSIC);

Review Comment:
   I missed that part. Thanks for catching it! 🙏



##########
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java:
##########
@@ -226,8 +226,8 @@ protected void configure() {
         });
 
     // Multiple Web UI
-    final WebAppContext defaultWebApp = setupWebAppContext(contexts, zConf, zConf.getString(ConfVars.ZEPPELIN_WAR), zConf.getServerContextPath());
-    final WebAppContext nextWebApp = setupWebAppContext(contexts, zConf, zConf.getString(ConfVars.ZEPPELIN_ANGULAR_WAR), WEB_APP_CONTEXT_NEXT);
+    final WebAppContext defaultWebApp = setupWebAppContext(contexts, zConf, zConf.getString(ConfVars.ZEPPELIN_WAR), WEB_APP_CONTEXT_CLASSIC);

Review Comment:
   I missed that part. Thanks for catching it! 🙏



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2323843040

   I've made a new issue regarding UI type persistence feature.
   I believe there are some points that need further discussion. Please feel free to comment on the issue.
   https://issues.apache.org/jira/browse/ZEPPELIN-6074


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2326082673

   As all comments are addressed, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2309200527

   By the way, I assume we can deploy two versions of Apache Zeppelin with current and new UI in some ways like setting parameters when packaging them and so on. However, your change supports only running Zeppelin with the new UI. Do you have any idea? :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2309593609

   >We have the 'web-angular' profile, which builds the new user interface. This should definitely be switched on by default when the default interface is changed.
   As far as I can see, this change does not result in running Zeppelin with the new UI.
   
   Yes, correct. Moreover, even if we include the profile, we still need to change some server code as ZeppelinServer has a hardcoded configuration for the current and new UI.
   
   By the way, for the improvement of the new UI, deploying the new UI version would be helpful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on code in PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#discussion_r1731299798


##########
zeppelin-web-angular/src/app/share/header/header.component.html:
##########
@@ -67,7 +67,7 @@
           <li nz-menu-item (click)="logout()">Logout</li>
         </ng-container>
         <li nz-menu-divider></li>
-        <li nz-menu-item><a href="/">Old Version</a></li>
+        <li nz-menu-item><a href="/classic">Classic Version</a></li>

Review Comment:
   I prefer a more specific phrasing, so I'll try 'Switch to Classic UI' vs. 'Switch to Default UI'.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2314573593

   I would have liked more feedback from the community and improvements with the current solution. Unfortunately, there was only sporadic feedback.
   I see the change of user interfaces as uncritical, especially as it is easy to switch between the two.
   In my opinion, a separate release makes the release process and implementation unnecessarily complicated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#discussion_r1731289824


##########
zeppelin-web-angular/src/app/share/header/header.component.html:
##########
@@ -67,7 +67,7 @@
           <li nz-menu-item (click)="logout()">Logout</li>
         </ng-container>
         <li nz-menu-divider></li>
-        <li nz-menu-item><a href="/">Old Version</a></li>
+        <li nz-menu-item><a href="/classic">Classic Version</a></li>

Review Comment:
   should we use the same pattern? I suggest using either
   1. "Classic UI" vs. "Default UI" or
   2. "Switch to Classic UI" vs. "Switch to Default UI"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on code in PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#discussion_r1731258996


##########
zeppelin-web/src/components/navbar/navbar.html:
##########
@@ -106,7 +106,7 @@
               <li ng-if="ticket.principal && ticket.principal !== 'anonymous'" role="separator" style="margin: 5px 0;" class="divider"></li>
               <li ng-if="ticket.principal && ticket.principal !== 'anonymous'"><a ng-click="navbar.logout()">Logout</a></li>
               <li role="separator" style="margin: 5px 0;" class="divider"></li>
-              <li><a href="/next">Try the new Zeppelin</a></li>
+              <li><a href="/">Try the new Zeppelin</a></li>

Review Comment:
   Are you suggesting that we should change the "Try the new Zeppelin" text?
   I initially decided to keep it the same even after switching the default UI, thinking it would be natural for old UI users to see the same wording guiding them to the new UI.
   Do you have any alternative wordking in mind?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#discussion_r1731289824


##########
zeppelin-web-angular/src/app/share/header/header.component.html:
##########
@@ -67,7 +67,7 @@
           <li nz-menu-item (click)="logout()">Logout</li>
         </ng-container>
         <li nz-menu-divider></li>
-        <li nz-menu-item><a href="/">Old Version</a></li>
+        <li nz-menu-item><a href="/classic">Classic Version</a></li>

Review Comment:
   should we use the same words? I suggest using either
   1. "Classic UI" vs. "Default UI" or
   2. "Switch to Classic UI" vs. "Switch to Default UI"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2314577657

   Yes, I hope so. For the release project, we can edit the release script to release two versions but we still need to change some code in ZeppelinServer and so on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#issuecomment-2323816434

   @jongyoul 
   Are you suggesting that when someone enters the top-level URL of Zeppelin, they should be redirected to the most recently accessed UI? Or did you have sth else in mind?
   In any case, I think there might be additional aspects we need to discuss, so it might be a good idea to create a new issue ticket.
   I'll go ahead and register a new issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6064] Change default web UI to new UI [zeppelin]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 merged PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org