You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by kjmrknsn <gi...@git.apache.org> on 2018/11/26 15:36:15 UTC
[GitHub] spark pull request #23145: [MINOR][Docs] "a R interpreter" -> "an R interpre...
GitHub user kjmrknsn opened a pull request:
https://github.com/apache/spark/pull/23145
[MINOR][Docs] "a R interpreter" -> "an R interpreter"
## What changes were proposed in this pull request?
This PR changes the phrase of `a R interpreter` to `an R interpreter` on `docs/index.md`.
## How was this patch tested?
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kjmrknsn/spark docUpdate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/23145.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23145
----
commit 9f2f60b3b80b1ae63c9df38cbc3d5bc1010d4123
Author: Keiji Yoshida <kj...@...>
Date: 2018-11-26T15:29:16Z
[MINOR][Docs] "a R interpreter" -> "an R interpreter"
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs] "a R interpreter" -> "an R interpreter"
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23145
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99331/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs] "a R interpreter" -> "an R interpreter"
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23145
It's okay but mind taking another look the documentation and fix other typos while we are here? I'm pretty sure there are more.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by kjmrknsn <gi...@git.apache.org>.
Github user kjmrknsn commented on the issue:
https://github.com/apache/spark/pull/23145
Thanks for reviewing and merging.
I've just finished checking the whole documentation.
Here is the complete version of this PR : https://github.com/apache/spark/pull/23185
Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23145
**[Test build #99331 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99331/testReport)** for PR 23145 at commit [`b43b9ac`](https://github.com/apache/spark/commit/b43b9ac86b13df555962344b178f8bf8493032e5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23145
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23145
I think this is fine to merge, this is a good batch of grammar fixes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs] "a R interpreter" -> "an R interpreter"
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23145
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23145
**[Test build #99344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99344/testReport)** for PR 23145 at commit [`eeb1c83`](https://github.com/apache/spark/commit/eeb1c83f9ad29edeb6b1929fc6e63f92b018e9d9).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23145
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23145: [MINOR][Docs] "a R interpreter" -> "an R interpre...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/23145#discussion_r236546043
--- Diff: docs/index.md ---
@@ -67,7 +67,7 @@ Example applications are also provided in Python. For example,
./bin/spark-submit examples/src/main/python/pi.py 10
Spark also provides an experimental [R API](sparkr.html) since 1.4 (only DataFrames APIs included).
--- End diff --
tbh, I'm not sure this should be called "an experimental [R API]"
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23145
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23145
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5421/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by kjmrknsn <gi...@git.apache.org>.
Github user kjmrknsn commented on the issue:
https://github.com/apache/spark/pull/23145
Sorry, this PR is still WIP. I'll continue to check the documentation later. Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23145
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23145: [MINOR][Docs][WIP] Fix Typos
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23145#discussion_r237564429
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1634,7 +1634,7 @@ returned through `Dataset.writeStream()`. You will have to specify one or more o
- *Query name:* Optionally, specify a unique name of the query for identification.
-- *Trigger interval:* Optionally, specify the trigger interval. If it is not specified, the system will check for availability of new data as soon as the previous processing has completed. If a trigger time is missed because the previous processing has not completed, then the system will trigger processing immediately.
+- *Trigger interval:* Optionally, specify the trigger interval. If it is not specified, the system will check for availability of new data as soon as the previous processing has been completed. If a trigger time is missed because the previous processing has not been completed, then the system will trigger processing immediately.
--- End diff --
"has completed" is actually correct, but the passive voice here is grammatical too.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23145: [MINOR][Docs][WIP] Fix Typos
Posted by kjmrknsn <gi...@git.apache.org>.
Github user kjmrknsn commented on a diff in the pull request:
https://github.com/apache/spark/pull/23145#discussion_r236909978
--- Diff: docs/index.md ---
@@ -67,7 +67,7 @@ Example applications are also provided in Python. For example,
./bin/spark-submit examples/src/main/python/pi.py 10
Spark also provides an experimental [R API](sparkr.html) since 1.4 (only DataFrames APIs included).
--- End diff --
OK, `experimental` has been removed. https://github.com/apache/spark/pull/23145/files#diff-1a523bd9fa0dbf998008b37579210e12
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23145
**[Test build #99344 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99344/testReport)** for PR 23145 at commit [`eeb1c83`](https://github.com/apache/spark/commit/eeb1c83f9ad29edeb6b1929fc6e63f92b018e9d9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23145: [MINOR][Docs][WIP] Fix Typos
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/23145#discussion_r236765511
--- Diff: docs/index.md ---
@@ -67,7 +67,7 @@ Example applications are also provided in Python. For example,
./bin/spark-submit examples/src/main/python/pi.py 10
Spark also provides an experimental [R API](sparkr.html) since 1.4 (only DataFrames APIs included).
--- End diff --
let's remove `experimental`, WDYT?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs] "a R interpreter" -> "an R interpreter"
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23145
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23145
**[Test build #99331 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99331/testReport)** for PR 23145 at commit [`b43b9ac`](https://github.com/apache/spark/commit/b43b9ac86b13df555962344b178f8bf8493032e5).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23145: [MINOR][Docs][WIP] Fix Typos
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23145
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs] "a R interpreter" -> "an R interpreter"
Posted by kjmrknsn <gi...@git.apache.org>.
Github user kjmrknsn commented on the issue:
https://github.com/apache/spark/pull/23145
OK, I'll check the whole documentation later. Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5409/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23145
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23145: [MINOR][Docs][WIP] Fix Typos
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99344/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23145: [MINOR][Docs] "a R interpreter" -> "an R interpre...
Posted by kjmrknsn <gi...@git.apache.org>.
Github user kjmrknsn commented on a diff in the pull request:
https://github.com/apache/spark/pull/23145#discussion_r236549454
--- Diff: docs/index.md ---
@@ -67,7 +67,7 @@ Example applications are also provided in Python. For example,
./bin/spark-submit examples/src/main/python/pi.py 10
Spark also provides an experimental [R API](sparkr.html) since 1.4 (only DataFrames APIs included).
--- End diff --
Should we remove the "experimental" adjective?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org