You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openjpa.apache.org by fa...@apache.org on 2009/05/15 00:52:03 UTC

svn commit: r774955 - in /openjpa/trunk: openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/criteria/TestTypesafeCriteria.java openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/PathImpl.java

Author: faywang
Date: Thu May 14 22:52:03 2009
New Revision: 774955

URL: http://svn.apache.org/viewvc?rev=774955&view=rev
Log:
OPENJPA-1013: IS EMPTY/SIZE() support for criteria query

Modified:
    openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/criteria/TestTypesafeCriteria.java
    openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/PathImpl.java

Modified: openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/criteria/TestTypesafeCriteria.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/criteria/TestTypesafeCriteria.java?rev=774955&r1=774954&r2=774955&view=diff
==============================================================================
--- openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/criteria/TestTypesafeCriteria.java (original)
+++ openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/criteria/TestTypesafeCriteria.java Thu May 14 22:52:03 2009
@@ -273,7 +273,6 @@
         assertEquivalence(q, jpql);
     }
     
-    @AllowFailure
     public void testRestrictQueryResult2() {
         String jpql = "SELECT o FROM Order o WHERE o.lineItems IS EMPTY";
         CriteriaQuery q = cb.create();
@@ -339,7 +338,6 @@
         assertEquivalence(q, jpql);
     }
     
-    @AllowFailure
     public void testExpression5() {
         String jpql = "SELECT SIZE(d.employees) FROM Department d " + 
             "WHERE d.name = 'Sales'";

Modified: openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/PathImpl.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/PathImpl.java?rev=774955&r1=774954&r2=774955&view=diff
==============================================================================
--- openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/PathImpl.java (original)
+++ openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/PathImpl.java Thu May 14 22:52:03 2009
@@ -83,8 +83,7 @@
     }
 
     public Expression get(AbstractCollection collection) {
-        // TODO Auto-generated method stub
-        throw new AbstractMethodError();
+        return new PathImpl(this, (Members.BaseCollection) collection);
     }
 
     public Expression get(Map collection) {