[GitHub] [solr] dsmiley commented on pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

[GitBox <gi...@apache.org>]

dsmiley commented on pull request #553:
URL: https://github.com/apache/solr/pull/553#issuecomment-1021837229


   When doing any non-trivial change to dependencies (as was done here), I strongly recommend reading what Dawid wrote: `help/dependencies.txt`.  In particular, I find this useful:
   
       gradlew -p solr/core dependencies --configuration runtimeClasspath
   
   And here I found it useful to save this and do a diff of this output to compare with this PR and without this PR.  **Wow**; tons of added stuff like okhttp and kotlin and lots of stuff.  Is all this really needed?  Honestly this is where your expertise comes into play.  My only gauge is if tests pass without the dependency.  I wish this dependency tree might be committed to source control so that if people mess with the dependencies, the impact would be shown in a useful way in the review process.
   
   If you want to remove some particular transitive:false additions (as you did to many places), then do so one at a time where you then carefully observe the changes to the versions.lock file and dependency tree and ensure the additions are good (e.g. compile; run tests perhaps) before moving onto the next.  Maybe even do a commit in-between.  I found the `gw why --hash=deadbeef` command useful too.  I did all this when I did the big dependency cleanup a few months ago.  You may find added libs that we don't actually need; they should be excluded.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org