[GitHub] [iceberg] szehon-ho commented on a diff in pull request #7551: Core: Check for all specs in partitionsTable

["szehon-ho (via GitHub)" <gi...@apache.org>]

szehon-ho commented on code in PR #7551:
URL: https://github.com/apache/iceberg/pull/7551#discussion_r1190463368


##########
core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java:
##########
@@ -805,6 +807,47 @@ public void testPartitionSpecEvolutionRemoval() {
     }
   }
 
+  @Test
+  public void testPartitionSpecEvolutionToUnpartitioned() throws IOException {

Review Comment:
   Actually we have a test specifically for this: TestMetadataTableScansWithPartitionEvolution, for organization purpose?  Could we move it there? 
   
   Also another question, does this test the case?  I thought it was only failing on V2, because in V1 the partition transform remains as void on the latest spec, when removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org