You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@archiva.apache.org by Brett Porter <br...@apache.org> on 2014/01/30 15:54:13 UTC
Re: svn commit: r1562340 - /archiva/branches/archiva-1.3.x/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/test/java/org/apache/maven/archiva/consumers/core/repository/CleanupReleasedSnapshotsRepositoryPurgeTest.java
Hi,
This does change the semantic (thought it may not affect the test that much), as INDEX_PATH is a zip file - I wonder if you just needed file.getParentFile().mkdirs()? Or is there a problem with file.createNewFile() that it needs to actually create something?
Thanks,
Brett
On 29 Jan 2014, at 12:34 pm, skygo@apache.org wrote:
> Author: skygo
> Date: Wed Jan 29 01:34:02 2014
> New Revision: 1562340
>
> URL: http://svn.apache.org/r1562340
> Log:
> fix test for windoz os (hope not breaking semantic)
>
> Modified:
> archiva/branches/archiva-1.3.x/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/test/java/org/apache/maven/archiva/consumers/core/repository/CleanupReleasedSnapshotsRepositoryPurgeTest.java
>
> Modified: archiva/branches/archiva-1.3.x/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/test/java/org/apache/maven/archiva/consumers/core/repository/CleanupReleasedSnapshotsRepositoryPurgeTest.java
> URL: http://svn.apache.org/viewvc/archiva/branches/archiva-1.3.x/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/test/java/org/apache/maven/archiva/consumers/core/repository/CleanupReleasedSnapshotsRepositoryPurgeTest.java?rev=1562340&r1=1562339&r2=1562340&view=diff
> ==============================================================================
> --- archiva/branches/archiva-1.3.x/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/test/java/org/apache/maven/archiva/consumers/core/repository/CleanupReleasedSnapshotsRepositoryPurgeTest.java (original)
> +++ archiva/branches/archiva-1.3.x/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/test/java/org/apache/maven/archiva/consumers/core/repository/CleanupReleasedSnapshotsRepositoryPurgeTest.java Wed Jan 29 01:34:02 2014
> @@ -137,6 +137,9 @@ public class CleanupReleasedSnapshotsRep
> listenerControl.replay();
>
> File file = new File( repoRoot, INDEX_PATH );
> + // windows fix
> + file.mkdirs();
> +
> file.createNewFile();
> assertTrue( file.exists() );
>
>
>
--
Brett Porter @brettporter
http://brettporter.wordpress.com/
http://au.linkedin.com/in/brettporter
RE: svn commit: r1562340 - /archiva/branches/archiva-1.3.x/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/test/java/org/apache/maven/archiva/consumers/core/repository/CleanupReleasedSnapshotsRepositoryPurgeTest.java
Posted by Eric Barboni <sk...@apache.org>.
Hi,
Sorry but I have a ( snapshot computer jdk8 and so one) difficult to
compile (jpox issue)
May it be the {\\} is considered as separator on windows os :(
INDEX_PATH = ".index\\nexus-maven-repository-index.zip"; and on linux macos
it's a normal char for a file
Os wants first folder .index to be created to put nexus-*-.zip inside
Eric
-----Message d'origine-----
De : Brett Porter [mailto:brett@porterclan.net] De la part de Brett Porter
Envoyé : jeudi 30 janvier 2014 15:54
À : dev@archiva.apache.org
Objet : Re: svn commit: r1562340 -
/archiva/branches/archiva-1.3.x/archiva-modules/archiva-base/archiva-consume
rs/archiva-core-consumers/src/test/java/org/apache/maven/archiva/consumers/c
ore/repository/CleanupReleasedSnapshotsRepositoryPurgeTest.java
Hi,
This does change the semantic (thought it may not affect the test that
much), as INDEX_PATH is a zip file - I wonder if you just needed
file.getParentFile().mkdirs()? Or is there a problem with
file.createNewFile() that it needs to actually create something?
Thanks,
Brett
On 29 Jan 2014, at 12:34 pm, skygo@apache.org wrote:
> Author: skygo
> Date: Wed Jan 29 01:34:02 2014
> New Revision: 1562340
>
> URL: http://svn.apache.org/r1562340
> Log:
> fix test for windoz os (hope not breaking semantic)
>
> Modified:
>
> archiva/branches/archiva-1.3.x/archiva-modules/archiva-base/archiva-co
> nsumers/archiva-core-consumers/src/test/java/org/apache/maven/archiva/
> consumers/core/repository/CleanupReleasedSnapshotsRepositoryPurgeTest.
> java
>
> Modified:
> archiva/branches/archiva-1.3.x/archiva-modules/archiva-base/archiva-co
> nsumers/archiva-core-consumers/src/test/java/org/apache/maven/archiva/
> consumers/core/repository/CleanupReleasedSnapshotsRepositoryPurgeTest.
> java
> URL:
> http://svn.apache.org/viewvc/archiva/branches/archiva-1.3.x/archiva-mo
> dules/archiva-base/archiva-consumers/archiva-core-consumers/src/test/j
> ava/org/apache/maven/archiva/consumers/core/repository/CleanupReleased
> SnapshotsRepositoryPurgeTest.java?rev=1562340&r1=1562339&r2=1562340&vi
> ew=diff
> ======================================================================
> ========
> ---
> archiva/branches/archiva-1.3.x/archiva-modules/archiva-base/archiva-co
> nsumers/archiva-core-consumers/src/test/java/org/apache/maven/archiva/
> consumers/core/repository/CleanupReleasedSnapshotsRepositoryPurgeTest.
> java (original)
> +++ archiva/branches/archiva-1.3.x/archiva-modules/archiva-base/archiv
> +++ a-consumers/archiva-core-consumers/src/test/java/org/apache/maven/
> +++ archiva/consumers/core/repository/CleanupReleasedSnapshotsReposito
> +++ ryPurgeTest.java Wed Jan 29 01:34:02 2014
> @@ -137,6 +137,9 @@ public class CleanupReleasedSnapshotsRep
> listenerControl.replay();
>
> File file = new File( repoRoot, INDEX_PATH );
> + // windows fix
> + file.mkdirs();
> +
> file.createNewFile();
> assertTrue( file.exists() );
>
>
>
--
Brett Porter @brettporter
http://brettporter.wordpress.com/
http://au.linkedin.com/in/brettporter