You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/03 12:52:44 UTC
[GitHub] [hudi] codope opened a new pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
codope opened a new pull request #3917:
URL: https://github.com/apache/hudi/pull/3917
## What is the purpose of the pull request
`spark.sql.parquet.writeLegacyFormat` was harcoded to false in `HoodieRowParquetWriteSupport`. In some cases, users need to set it to true. From a user on Slack:
```
Reason to use this config:
Current Bulk insert use spark dataframe writer and don't do avro conversion. The decimal columns in my DF are written as INT32 type in parquet.
The upsert functionality which uses avro conversion is generating Fixed Length byte array for decimal types which is failing with datatype mismatch.
```
## Brief change log
- Make `spark.sql.parquet.writeLegacyFormat` configurable.
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3917:
URL: https://github.com/apache/hudi/pull/3917#issuecomment-959056814
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114",
"triggerID" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97e4d25248219adaf9ac40128cc345bd42f9eaf6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3917:
URL: https://github.com/apache/hudi/pull/3917#issuecomment-961588835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114",
"triggerID" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97e4d25248219adaf9ac40128cc345bd42f9eaf6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3917:
URL: https://github.com/apache/hudi/pull/3917#issuecomment-961588835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114",
"triggerID" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97e4d25248219adaf9ac40128cc345bd42f9eaf6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3917:
URL: https://github.com/apache/hudi/pull/3917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3917:
URL: https://github.com/apache/hudi/pull/3917#issuecomment-959056814
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97e4d25248219adaf9ac40128cc345bd42f9eaf6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3917:
URL: https://github.com/apache/hudi/pull/3917#issuecomment-959056814
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114",
"triggerID" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97e4d25248219adaf9ac40128cc345bd42f9eaf6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3917:
URL: https://github.com/apache/hudi/pull/3917#issuecomment-959056814
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97e4d25248219adaf9ac40128cc345bd42f9eaf6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3917:
URL: https://github.com/apache/hudi/pull/3917#issuecomment-961588835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114",
"triggerID" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97e4d25248219adaf9ac40128cc345bd42f9eaf6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3917:
URL: https://github.com/apache/hudi/pull/3917#issuecomment-959056814
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114",
"triggerID" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97e4d25248219adaf9ac40128cc345bd42f9eaf6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3917:
URL: https://github.com/apache/hudi/pull/3917#issuecomment-959056814
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114",
"triggerID" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97e4d25248219adaf9ac40128cc345bd42f9eaf6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3917:
URL: https://github.com/apache/hudi/pull/3917#issuecomment-959056814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3917:
URL: https://github.com/apache/hudi/pull/3917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3917:
URL: https://github.com/apache/hudi/pull/3917#issuecomment-959056814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3917:
URL: https://github.com/apache/hudi/pull/3917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3917:
URL: https://github.com/apache/hudi/pull/3917#issuecomment-959056814
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114",
"triggerID" : "97e4d25248219adaf9ac40128cc345bd42f9eaf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97e4d25248219adaf9ac40128cc345bd42f9eaf6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3114)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3917: [HUDI-2526] Make spark.sql.parquet.writeLegacyFormat configurable
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3917:
URL: https://github.com/apache/hudi/pull/3917#issuecomment-959056814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org