[incubator-nemo] branch master updated: [NEMO-133] Remove run_external_app.sh (#58)

[ja...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jangho pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nemo.git


The following commit(s) were added to refs/heads/master by this push:
     new 6db5b07  [NEMO-133] Remove run_external_app.sh (#58)
6db5b07 is described below

commit 6db5b071b1f69ca1fa749f02aef1a9504997fd82
Author: John Yang <jo...@gmail.com>
AuthorDate: Thu Jun 28 16:28:12 2018 +0900

    [NEMO-133] Remove run_external_app.sh (#58)
    
    JIRA: [NEMO-133: Remove run_external_app.sh](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-133)
    
    **Major changes:**
    - Remove run_external_app.sh
    - Fix README
    
    **Minor changes to note:**
    - N/A
    
    **Tests for the changes:**
    - N/A
    
    **Other comments:**
    - N/A
    
    resolves [NEMO-133](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-133)
---
 README.md               | 12 ------------
 bin/run_external_app.sh | 20 --------------------
 2 files changed, 32 deletions(-)

diff --git a/README.md b/README.md
index 79a4165..d7b1db8 100644
--- a/README.md
+++ b/README.md
@@ -64,18 +64,6 @@ Please refer to the [Contribution guideline](.github/CONTRIBUTING.md) to contrib
 * Run only unit tests and install: `mvn clean install -DskipITs -T 2C`
 
 ## Running Beam applications
-### Running an external Beam application
-* Use run_external_app.sh instead of run.sh
-* Set the first argument the path to the external Beam application jar
-
-```bash
-./bin/run_external_app.sh \
-    `pwd`/nemo_app/target/bd17f-1.0-SNAPSHOT.jar \
-    -job_id mapreduce \
-    -executor_json `pwd`/examples/resources/sample_executor_resources.json \
-    -user_main MapReduce \
-    -user_args "`pwd`/mr_input_data `pwd`/nemo_output/output_data"
-```
 
 ### Configurable options
 * `-job_id`: ID of the Beam job
diff --git a/bin/run_external_app.sh b/bin/run_external_app.sh
deleted file mode 100755
index 5a95935..0000000
--- a/bin/run_external_app.sh
+++ /dev/null
@@ -1,20 +0,0 @@
-#!/usr/bin/env bash
-#
-# Copyright (C) 2018 Seoul National University
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#         http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-parent_path=$( cd "$(dirname "${BASH_SOURCE[0]}")" ; pwd -P )
-pushd $parent_path
-java -cp examples/target/nemo-examples-0.1-SNAPSHOT-shaded.jar:$1:`yarn classpath` edu.snu.nemo.client.JobLauncher "${@:2}"
-popd