You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Aditya Auradkar <aa...@linkedin.com> on 2015/06/22 19:35:30 UTC
Review Request 35734: Patch for KAFKA-2293
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35734/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-2293
https://issues.apache.org/jira/browse/KAFKA-2293
Repository: kafka
Description
-------
Fix for 2293
Diffs
-----
core/src/main/scala/kafka/cluster/Partition.scala 6cb647711191aee8d36e9ff15bdc2af4f1c95457
Diff: https://reviews.apache.org/r/35734/diff/
Testing
-------
Thanks,
Aditya Auradkar
Re: Review Request 35734: Patch for KAFKA-2293
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35734/#review88866
-----------------------------------------------------------
Ship it!
Minor comment: would use `%s` with `TopicAndPartition` instead of `%s,%d`. I'll do this on check-in.
- Joel Koshy
On June 22, 2015, 5:35 p.m., Aditya Auradkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35734/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 5:35 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2293
> https://issues.apache.org/jira/browse/KAFKA-2293
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Fix for 2293
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/cluster/Partition.scala 6cb647711191aee8d36e9ff15bdc2af4f1c95457
>
> Diff: https://reviews.apache.org/r/35734/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aditya Auradkar
>
>
Re: Review Request 35734: Patch for KAFKA-2293
Posted by Grant Henke <gr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35734/#review92416
-----------------------------------------------------------
Ship it!
Ship It!
- Grant Henke
On June 22, 2015, 5:35 p.m., Aditya Auradkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35734/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 5:35 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2293
> https://issues.apache.org/jira/browse/KAFKA-2293
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Fix for 2293
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/cluster/Partition.scala 6cb647711191aee8d36e9ff15bdc2af4f1c95457
>
> Diff: https://reviews.apache.org/r/35734/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aditya Auradkar
>
>