You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/05/15 05:02:26 UTC
Review Request: Fixed mesos and libprocess to pipe all close()s through
os::close().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11169/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/launcher/executor.cpp 58ec848c543c13898ea33de0bb0255e5be0b7b24
src/slave/process_isolator.cpp 11a5d18fc27131d80ff653480e56802431395759
third_party/libprocess/include/process/socket.hpp f466963135aef490e08256768c36eb33ff4e2a56
third_party/libprocess/src/encoder.hpp 12b3ffaa4a63e33e096a26b514753eda61131a51
third_party/libprocess/src/httpd.cpp 49bcecef3f35d08679919266eb78fc3e27e5c45f
third_party/libprocess/src/net.hpp 8359526ac9bfb23360c5e9dac5bbf7379c78256c
third_party/libprocess/src/process.cpp 197611fffe1d6f76b011211cf153a41c79c125a1
Diff: https://reviews.apache.org/r/11169/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed mesos and libprocess to pipe all close()s through
os::close().
Posted by Vinod Kone <vi...@gmail.com>.
> On May 15, 2013, 3:05 p.m., Benjamin Hindman wrote:
> > Please separate libprocess and Mesos changes.
aargh. missed it again. fixed
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11169/#review20591
-----------------------------------------------------------
On May 15, 2013, 3:02 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11169/
> -----------------------------------------------------------
>
> (Updated May 15, 2013, 3:02 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 58ec848c543c13898ea33de0bb0255e5be0b7b24
> src/slave/process_isolator.cpp 11a5d18fc27131d80ff653480e56802431395759
> third_party/libprocess/include/process/socket.hpp f466963135aef490e08256768c36eb33ff4e2a56
> third_party/libprocess/src/encoder.hpp 12b3ffaa4a63e33e096a26b514753eda61131a51
> third_party/libprocess/src/httpd.cpp 49bcecef3f35d08679919266eb78fc3e27e5c45f
> third_party/libprocess/src/net.hpp 8359526ac9bfb23360c5e9dac5bbf7379c78256c
> third_party/libprocess/src/process.cpp 197611fffe1d6f76b011211cf153a41c79c125a1
>
> Diff: https://reviews.apache.org/r/11169/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed mesos and libprocess to pipe all close()s through
os::close().
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11169/#review20591
-----------------------------------------------------------
Please separate libprocess and Mesos changes.
third_party/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/11169/#comment42426>
No longer a perror (necessarily). Now do 'std::cerr << "Failed to close socket: " << close.error() << std::endl;' please.
- Benjamin Hindman
On May 15, 2013, 3:02 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11169/
> -----------------------------------------------------------
>
> (Updated May 15, 2013, 3:02 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 58ec848c543c13898ea33de0bb0255e5be0b7b24
> src/slave/process_isolator.cpp 11a5d18fc27131d80ff653480e56802431395759
> third_party/libprocess/include/process/socket.hpp f466963135aef490e08256768c36eb33ff4e2a56
> third_party/libprocess/src/encoder.hpp 12b3ffaa4a63e33e096a26b514753eda61131a51
> third_party/libprocess/src/httpd.cpp 49bcecef3f35d08679919266eb78fc3e27e5c45f
> third_party/libprocess/src/net.hpp 8359526ac9bfb23360c5e9dac5bbf7379c78256c
> third_party/libprocess/src/process.cpp 197611fffe1d6f76b011211cf153a41c79c125a1
>
> Diff: https://reviews.apache.org/r/11169/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>