You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/02 17:43:36 UTC
[GitHub] [arrow] kszucs opened a new pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
kszucs opened a new pull request #7621:
URL: https://github.com/apache/arrow/pull/7621
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653232832
Revision: 2f432d224959846d8d409fcf642ccec91b645015
Submitted crossbow builds: [ursa-labs/crossbow @ actions-377](https://github.com/ursa-labs/crossbow/branches/all?query=actions-377)
|Task|Status|
|----|------|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm edited a comment on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
wesm edited a comment on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653230746
OK based on reading https://github.com/google/brotli/pull/655 unfortunately it appears that the conda-forge Brotli static libraries are broken on Windows. I'll open a ticket for that feedstock. EDIT: actually I'm not sure. Flailing trying everything I can here...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653248351
Revision: 0722674b2743bcb9fba3e95cbe06e293d2b428c0
Submitted crossbow builds: [ursa-labs/crossbow @ actions-378](https://github.com/ursa-labs/crossbow/branches/all?query=actions-378)
|Task|Status|
|----|------|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653197684
Revision: 7598a021ca12c84227702176c495635603c088fb
Submitted crossbow builds: [ursa-labs/crossbow @ actions-376](https://github.com/ursa-labs/crossbow/branches/all?query=actions-376)
|Task|Status|
|----|------|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653195997
Take a closer look at the brotli_ep build
https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L877
When you use `-DBrotli_SOURCE=BUNDLED`, it uses the static libraries regardless of whether `ARROW_BROTLI_USE_SHARED` is set or not. So the linking error that's happening must be caused by something else
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653139804
@github-actions crossbow submit wheel-win-cp37m
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653266761
Closing this. Brotli is not the problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653171393
Revision: f434ec6bdd509ce9a8872bad0a98c8ef5af172f5
Submitted crossbow builds: [ursa-labs/crossbow @ actions-375](https://github.com/ursa-labs/crossbow/branches/all?query=actions-375)
|Task|Status|
|----|------|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653140442
Revision: 1e8fecd3616b988c92a03ad58bebe122e32588c6
Submitted crossbow builds: [ursa-labs/crossbow @ actions-374](https://github.com/ursa-labs/crossbow/branches/all?query=actions-374)
|Task|Status|
|----|------|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653180991
I think if we link brotly dinamically than we need to bundle the dll in pyarrow/cmakelist and setup.py into the wheel, so my original plan was to link it statically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653197213
I think part of the issue is that brotli is being installed by conda so this iteration will hopefully fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7621:
URL: https://github.com/apache/arrow/pull/7621
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653232236
@github-actions crossbow submit wheel-win-cp37m
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653247966
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653196984
@github-actions crossbow submit wheel-win-cp37m
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653169897
I'm pretty confident you're going to have to restore -DBUILD_SHARED_LIBS=OFF to the brotli_ep build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653170709
@github-actions crossbow submit wheel-win-cp37m
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7621: [Packaging][Python] Link brotli statically in the windows wheels
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7621:
URL: https://github.com/apache/arrow/pull/7621#issuecomment-653230746
OK based on reading https://github.com/google/brotli/pull/655 unfortunately it appears that the conda-forge Brotli static libraries are broken on Windows. I'll open a ticket for that feedstock
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org