You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/14 10:24:42 UTC

[GitHub] [kafka] vamossagar12 opened a new pull request #9432: KAFKA-10559 | Initial Commit

vamossagar12 opened a new pull request #9432:
URL: https://github.com/apache/kafka/pull/9432


   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vamossagar12 commented on pull request #9432: KAFKA-10559: Not letting TimeoutException shutdown the app during internal topic validation

Posted by GitBox <gi...@apache.org>.
vamossagar12 commented on pull request #9432:
URL: https://github.com/apache/kafka/pull/9432#issuecomment-709801023


   Thanks @mjsax . I thought these were time out related tests so ended up removing them. Thanks for the feedback :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #9432: KAFKA-10559: Not letting TimeoutException shutdown the app during internal topic validation

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #9432:
URL: https://github.com/apache/kafka/pull/9432#issuecomment-709610635


   LGTM
   
   Looks like the Java 8 build may have stalled? The Java 11 & 15 builds both passed a while ago


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax merged pull request #9432: KAFKA-10559: Not letting TimeoutException shutdown the app during internal topic validation

Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #9432:
URL: https://github.com/apache/kafka/pull/9432


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #9432: KAFKA-10559: Not letting TimeoutException shutdown the app during internal topic validation

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #9432:
URL: https://github.com/apache/kafka/pull/9432#issuecomment-709635418


   Follow up PR: https://github.com/apache/kafka/pull/9446


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #9432: KAFKA-10559: Not letting TimeoutException shutdown the app during internal topic validation

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #9432:
URL: https://github.com/apache/kafka/pull/9432#issuecomment-713023808


   Well, that are timeout related: they checked if we send the shut-down signal. After the change, they should check if the `TimeoutException` is thrown and only kills the local thread. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #9432: KAFKA-10559: Not letting TimeoutException shutdown the app during internal topic validation

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #9432:
URL: https://github.com/apache/kafka/pull/9432#issuecomment-709619232


   Thanks for the PR @vamossagar12!
   
   No ideal to just remove the test instead of adjusting them, but we can do this in a follow up PR. @ableegoldman told me she will take care of it.
   
   Merged to `trunk` and cherry-picked to `2.7` branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org