You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/19 10:08:45 UTC

[GitHub] [pulsar-client-go] labuladong opened a new pull request, #849: [issue 840][client] batchReceive support for consumer

labuladong opened a new pull request, #849:
URL: https://github.com/apache/pulsar-client-go/pull/849

   Note: this pr is a draft, waiting #848 to be merged.
   
   Master Issue: #840
   
   ### Motivation
   
   Add `batchReceive` method for consumers
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] frodopwns commented on pull request #849: [issue 840][client] batchReceive support for consumer

Posted by "frodopwns (via GitHub)" <gi...@apache.org>.
frodopwns commented on PR #849:
URL: https://github.com/apache/pulsar-client-go/pull/849#issuecomment-1653819991

   How is this working progressing? I too have need of batch receive functionality in Go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] Gleiphir2769 commented on pull request #849: [issue 840][client] batchReceive support for consumer

Posted by GitBox <gi...@apache.org>.
Gleiphir2769 commented on PR #849:
URL: https://github.com/apache/pulsar-client-go/pull/849#issuecomment-1328628719

   Hi  @labuladong , Does the batch index level ack will be supported in this PR?
   
   Or this PR is only used to support batch receive and the batch index ack is in another plan?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] labuladong commented on pull request #849: [issue 840][client] batchReceive support for consumer

Posted by GitBox <gi...@apache.org>.
labuladong commented on PR #849:
URL: https://github.com/apache/pulsar-client-go/pull/849#issuecomment-1330071645

   Hi @Gleiphir2769, for now, this pr is just for the batch receive policy. No implementation of batch index level ack.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org