You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/06 13:37:18 UTC
[GitHub] [flink] twalthr opened a new pull request #13967: [FLINK-20019][core] Support all conversion classes in Row.equals/hashCode
twalthr opened a new pull request #13967:
URL: https://github.com/apache/flink/pull/13967
## What is the purpose of the change
The Row.equals/hashCode cannot handle arrays in nested structures (e.g. Map, List) well. Since those methods are used for a variety of use cases. We should support all conversion classes of the table ecosystem in all combinations. Initial work for this has been done recently. But it would be good to finalize this for 1.12 as a preparation for FLIP-136.
## Brief change log
- Implement a deepHashCode for the `Row` class
- Make `RowUtils.deepEquals` and `RowUtils.deepHashCode` the default for `Row`
## Verifying this change
This change is already covered by existing tests and additionally tested in `RowTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #13967: [FLINK-20019][core] Support all conversion classes in Row.equals/hashCode
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #13967:
URL: https://github.com/apache/flink/pull/13967#discussion_r518821443
##########
File path: flink-core/src/main/java/org/apache/flink/types/Row.java
##########
@@ -45,6 +45,9 @@
*
* <p>A row instance is in principle {@link Serializable}. However, it may contain non-serializable fields
* in which case serialization will fail if the row is not serialized with Flink's serialization stack.
+ *
+ * <p>The {@link #equals(Object)} and {@link #hashCode()} methods of this class support all conversion
Review comment:
We fixed MapData in FLINK-17668. I think most internal data structures have a proper hashCode/equals now. But yes, we can also be more specific here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13967: [FLINK-20019][core] Support all conversion classes in Row.equals/hashCode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13967:
URL: https://github.com/apache/flink/pull/13967#issuecomment-723121066
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9196",
"triggerID" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d774a399923916e0a9415d0497f0a7fb79a8c92 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9196)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13967: [FLINK-20019][core] Support all conversion classes in Row.equals/hashCode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13967:
URL: https://github.com/apache/flink/pull/13967#issuecomment-723121066
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9196",
"triggerID" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"triggerType" : "PUSH"
}, {
"hash" : "b5e633b4b1b740e85c59d505e18d832d8abdc27c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9250",
"triggerID" : "b5e633b4b1b740e85c59d505e18d832d8abdc27c",
"triggerType" : "PUSH"
}, {
"hash" : "7fdef9acd1f4033db414bc397690b802c2014132",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9254",
"triggerID" : "7fdef9acd1f4033db414bc397690b802c2014132",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fdef9acd1f4033db414bc397690b802c2014132 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9254)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13967: [FLINK-20019][core] Support all conversion classes in Row.equals/hashCode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13967:
URL: https://github.com/apache/flink/pull/13967#issuecomment-723121066
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d774a399923916e0a9415d0497f0a7fb79a8c92 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #13967: [FLINK-20019][core] Support all conversion classes in Row.equals/hashCode
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #13967:
URL: https://github.com/apache/flink/pull/13967
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13967: [FLINK-20019][core] Support all conversion classes in Row.equals/hashCode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13967:
URL: https://github.com/apache/flink/pull/13967#issuecomment-723121066
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9196",
"triggerID" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d774a399923916e0a9415d0497f0a7fb79a8c92 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9196)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13967: [FLINK-20019][core] Support all conversion classes in Row.equals/hashCode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13967:
URL: https://github.com/apache/flink/pull/13967#issuecomment-723121066
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9196",
"triggerID" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"triggerType" : "PUSH"
}, {
"hash" : "b5e633b4b1b740e85c59d505e18d832d8abdc27c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9250",
"triggerID" : "b5e633b4b1b740e85c59d505e18d832d8abdc27c",
"triggerType" : "PUSH"
}, {
"hash" : "7fdef9acd1f4033db414bc397690b802c2014132",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9254",
"triggerID" : "7fdef9acd1f4033db414bc397690b802c2014132",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5e633b4b1b740e85c59d505e18d832d8abdc27c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9250)
* 7fdef9acd1f4033db414bc397690b802c2014132 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9254)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13967: [FLINK-20019][core] Support all conversion classes in Row.equals/hashCode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13967:
URL: https://github.com/apache/flink/pull/13967#issuecomment-723085983
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0d774a399923916e0a9415d0497f0a7fb79a8c92 (Fri Nov 06 13:40:16 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13967: [FLINK-20019][core] Support all conversion classes in Row.equals/hashCode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13967:
URL: https://github.com/apache/flink/pull/13967#issuecomment-723121066
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9196",
"triggerID" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"triggerType" : "PUSH"
}, {
"hash" : "b5e633b4b1b740e85c59d505e18d832d8abdc27c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9250",
"triggerID" : "b5e633b4b1b740e85c59d505e18d832d8abdc27c",
"triggerType" : "PUSH"
}, {
"hash" : "7fdef9acd1f4033db414bc397690b802c2014132",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9254",
"triggerID" : "7fdef9acd1f4033db414bc397690b802c2014132",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d774a399923916e0a9415d0497f0a7fb79a8c92 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9196)
* b5e633b4b1b740e85c59d505e18d832d8abdc27c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9250)
* 7fdef9acd1f4033db414bc397690b802c2014132 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9254)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13967: [FLINK-20019][core] Support all conversion classes in Row.equals/hashCode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13967:
URL: https://github.com/apache/flink/pull/13967#issuecomment-723121066
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9196",
"triggerID" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"triggerType" : "PUSH"
}, {
"hash" : "b5e633b4b1b740e85c59d505e18d832d8abdc27c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b5e633b4b1b740e85c59d505e18d832d8abdc27c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d774a399923916e0a9415d0497f0a7fb79a8c92 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9196)
* b5e633b4b1b740e85c59d505e18d832d8abdc27c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13967: [FLINK-20019][core] Support all conversion classes in Row.equals/hashCode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13967:
URL: https://github.com/apache/flink/pull/13967#issuecomment-723121066
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9196",
"triggerID" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"triggerType" : "PUSH"
}, {
"hash" : "b5e633b4b1b740e85c59d505e18d832d8abdc27c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9250",
"triggerID" : "b5e633b4b1b740e85c59d505e18d832d8abdc27c",
"triggerType" : "PUSH"
}, {
"hash" : "7fdef9acd1f4033db414bc397690b802c2014132",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fdef9acd1f4033db414bc397690b802c2014132",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d774a399923916e0a9415d0497f0a7fb79a8c92 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9196)
* b5e633b4b1b740e85c59d505e18d832d8abdc27c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9250)
* 7fdef9acd1f4033db414bc397690b802c2014132 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13967: [FLINK-20019][core] Support all conversion classes in Row.equals/hashCode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13967:
URL: https://github.com/apache/flink/pull/13967#issuecomment-723121066
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9196",
"triggerID" : "0d774a399923916e0a9415d0497f0a7fb79a8c92",
"triggerType" : "PUSH"
}, {
"hash" : "b5e633b4b1b740e85c59d505e18d832d8abdc27c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9250",
"triggerID" : "b5e633b4b1b740e85c59d505e18d832d8abdc27c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d774a399923916e0a9415d0497f0a7fb79a8c92 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9196)
* b5e633b4b1b740e85c59d505e18d832d8abdc27c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9250)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #13967: [FLINK-20019][core] Support all conversion classes in Row.equals/hashCode
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13967:
URL: https://github.com/apache/flink/pull/13967#discussion_r518814704
##########
File path: flink-core/src/main/java/org/apache/flink/types/Row.java
##########
@@ -45,6 +45,9 @@
*
* <p>A row instance is in principle {@link Serializable}. However, it may contain non-serializable fields
* in which case serialization will fail if the row is not serialized with Flink's serialization stack.
+ *
+ * <p>The {@link #equals(Object)} and {@link #hashCode()} methods of this class support all conversion
Review comment:
I think you mean "all **external** conversion classes"? Because it doesn't support the internal conversion classes, e.g. `MapData`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org