You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/12/03 08:56:57 UTC
[GitHub] [incubator-doris] morningman commented on a change in pull request
#2358: Remove VersionHash used to comparison in BE
morningman commented on a change in pull request #2358: Remove VersionHash used to comparison in BE
URL: https://github.com/apache/incubator-doris/pull/2358#discussion_r353046045
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -1932,10 +1932,8 @@ OLAPStatus SchemaChangeHandler::_validate_alter_result(TabletSharedPtr new_table
new_tablet->max_continuous_version_from_begining(&max_continuous_version, &max_continuous_version_hash);
LOG(INFO) << "find max continuous version of tablet=" << new_tablet->full_name()
<< ", start_version=" << max_continuous_version.first
- << ", end_version=" << max_continuous_version.second
- << ", version_hash=" << max_continuous_version_hash;
- if (max_continuous_version.second > request.alter_version
- || (max_continuous_version.second == request.alter_version && max_continuous_version_hash == request.alter_version_hash)) {
+ << ", end_version=" << max_continuous_version.second;
+ if (max_continuous_version.second > request.alter_version) {
Review comment:
```suggestion
if (max_continuous_version.second >= request.alter_version) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org