You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/08/05 03:54:48 UTC
[GitHub] [tvm] schell opened a new pull request #8665: Allow rust tvm build configuration through cargo features
schell opened a new pull request #8665:
URL: https://github.com/apache/tvm/pull/8665
* exposes TVM cmake config settings as cargo features (for settings that make some sense)
After https://github.com/octoml/tvm-build/pull/6 goes through we can update the cargo path to `tvm-build` and set this draft as ready to PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on pull request #8665: Allow rust tvm build configuration through cargo features
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #8665:
URL: https://github.com/apache/tvm/pull/8665#issuecomment-893818848
cc @vegaluisjose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch merged pull request #8665: Allow rust tvm build configuration through cargo features
Posted by GitBox <gi...@apache.org>.
jroesch merged pull request #8665:
URL: https://github.com/apache/tvm/pull/8665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] schell commented on pull request #8665: Allow rust tvm build configuration through cargo features
Posted by GitBox <gi...@apache.org>.
schell commented on pull request #8665:
URL: https://github.com/apache/tvm/pull/8665#issuecomment-894510602
Thank you for the fast turn-around :) 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8665: Allow rust tvm build configuration through cargo features
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8665:
URL: https://github.com/apache/tvm/pull/8665#discussion_r683797357
##########
File path: rust/tvm-rt/Cargo.toml
##########
@@ -33,7 +33,55 @@ default = ["dynamic-linking"]
dynamic-linking = ["tvm-sys/dynamic-linking"]
static-linking = ["tvm-sys/static-linking"]
standalone = ["tvm-sys/runtime-only"]
+runtime-only = ["tvm-sys/runtime-only"]
blas = ["ndarray/blas"]
+# Enabling any of the following features is like setting the value to "ON" in config.cmake.
+use-cuda = ["tvm-sys/use-cuda"]
Review comment:
hey @schell just wondering, is it possible to auto-generate this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] schell commented on a change in pull request #8665: Allow rust tvm build configuration through cargo features
Posted by GitBox <gi...@apache.org>.
schell commented on a change in pull request #8665:
URL: https://github.com/apache/tvm/pull/8665#discussion_r683809576
##########
File path: rust/tvm-rt/Cargo.toml
##########
@@ -33,7 +33,55 @@ default = ["dynamic-linking"]
dynamic-linking = ["tvm-sys/dynamic-linking"]
static-linking = ["tvm-sys/static-linking"]
standalone = ["tvm-sys/runtime-only"]
+runtime-only = ["tvm-sys/runtime-only"]
blas = ["ndarray/blas"]
+# Enabling any of the following features is like setting the value to "ON" in config.cmake.
+use-cuda = ["tvm-sys/use-cuda"]
Review comment:
I'm sure it's possible but it's definitely not standard. It would be a bespoke generator for sure.
This is the defacto Rust project declaration, so I think auto-generating it would be confusing for Rust contributors in the long run. I do agree that keeping these in sync with TVM proper will be a bit error prone though - especially since it has to happen in a number of crates in this repo. Unfortunately there doesn't seem to be any way to iterate over user-set features in Rust at the moment, which was what I was hoping to do to cut down on the boiler plate here.
Ultimately this approach is explicit, which is good - I learned about the CoreML support by adding these! But it does mean that the configurable features will always lag behind TVM proper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on a change in pull request #8665: Allow rust tvm build configuration through cargo features
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #8665:
URL: https://github.com/apache/tvm/pull/8665#discussion_r684408529
##########
File path: rust/tvm-rt/Cargo.toml
##########
@@ -33,7 +33,55 @@ default = ["dynamic-linking"]
dynamic-linking = ["tvm-sys/dynamic-linking"]
static-linking = ["tvm-sys/static-linking"]
standalone = ["tvm-sys/runtime-only"]
+runtime-only = ["tvm-sys/runtime-only"]
blas = ["ndarray/blas"]
+# Enabling any of the following features is like setting the value to "ON" in config.cmake.
+use-cuda = ["tvm-sys/use-cuda"]
Review comment:
Maybe we can think about this kind of stuff in the Backlog @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org