You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2014/05/21 08:33:31 UTC
Review Request 21760: SENTRY-191 Sentry Policy Service should not require
passing the RPC requestor's user/group information
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21760/
-----------------------------------------------------------
Review request for sentry and Sravya Tirukkovalur.
Bugs: SENTRY-191
https://issues.apache.org/jira/browse/SENTRY-191
Repository: sentry
Description
-------
The diff doesn't include the thrift generated code.
Handle the group resolution on Sentry store.
remove the requester group from all thrift RPC definitions.
The group mapping is set using a new config property, same Hadoop and Local group mapping support at this point
Diffs
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java b6f39ad
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationProvider.java de774f4
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/HadoopGroupMappingService.java 6c8fa95
sentry-provider/sentry-provider-db/pom.xml fca6c52
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 5f8a65f
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 8e58202
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java d06ac3c
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift a8b511d
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerWithoutKerberos.java 81a9ea4
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java 1e4ed17
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java 07352ab
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/LocalGroupMappingService.java a4d9cba
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/Context.java ce374c2
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestDatabaseProvider.java 176acee
Diff: https://reviews.apache.org/r/21760/diff/
Testing
-------
Updated the db provider test cases.
Thanks,
Prasad Mujumdar
Re: Review Request 21760: SENTRY-191 Sentry Policy Service should not
require passing the RPC requestor's user/group information
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21760/#review44242
-----------------------------------------------------------
Ship it!
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
<https://reviews.apache.org/r/21760/#comment78579>
I wonder if should restrict users to use same group mapping for sentry store and sentry itself. But we can do that if at all in a follow up.
- Sravya Tirukkovalur
On May 23, 2014, 6:05 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21760/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 6:05 p.m.)
>
>
> Review request for sentry and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-191
> https://issues.apache.org/jira/browse/SENTRY-191
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The diff doesn't include the thrift generated code.
> Handle the group resolution on Sentry store.
> remove the requester group from all thrift RPC definitions.
> The group mapping is set using a new config property, same Hadoop and Local group mapping support at this point
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java faa71c7
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationProvider.java de774f4
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/HadoopGroupMappingService.java 6c8fa95
> sentry-provider/sentry-provider-db/pom.xml fca6c52
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 5f8a65f
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 8e58202
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java d06ac3c
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift a8b511d
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerWithoutKerberos.java 81a9ea4
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java f51f518
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java 07352ab
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/LocalGroupMappingService.java a4d9cba
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java 19bf8cc
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/Context.java ce374c2
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestDatabaseProvider.java 7564829
>
> Diff: https://reviews.apache.org/r/21760/diff/
>
>
> Testing
> -------
>
> Updated the db provider test cases.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 21760: SENTRY-191 Sentry Policy Service should not
require passing the RPC requestor's user/group information
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21760/
-----------------------------------------------------------
(Updated May 23, 2014, 6:05 p.m.)
Review request for sentry and Sravya Tirukkovalur.
Changes
-------
Addressed review feedback
Rebase - needed to update some of the newer tests as per interface changes in this patch.
Bugs: SENTRY-191
https://issues.apache.org/jira/browse/SENTRY-191
Repository: sentry
Description
-------
The diff doesn't include the thrift generated code.
Handle the group resolution on Sentry store.
remove the requester group from all thrift RPC definitions.
The group mapping is set using a new config property, same Hadoop and Local group mapping support at this point
Diffs (updated)
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java faa71c7
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationProvider.java de774f4
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/HadoopGroupMappingService.java 6c8fa95
sentry-provider/sentry-provider-db/pom.xml fca6c52
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 5f8a65f
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 8e58202
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java d06ac3c
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift a8b511d
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerWithoutKerberos.java 81a9ea4
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java f51f518
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java 07352ab
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/LocalGroupMappingService.java a4d9cba
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java 19bf8cc
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/Context.java ce374c2
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestDatabaseProvider.java 7564829
Diff: https://reviews.apache.org/r/21760/diff/
Testing
-------
Updated the db provider test cases.
Thanks,
Prasad Mujumdar
Re: Review Request 21760: SENTRY-191 Sentry Policy Service should not
require passing the RPC requestor's user/group information
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21760/#review43785
-----------------------------------------------------------
Ship it!
Thanks Prasad, LGTM. Some nits below.
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java
<https://reviews.apache.org/r/21760/#comment78066>
This should be removed.
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java
<https://reviews.apache.org/r/21760/#comment78067>
Nit: Trailing white spaces here and else where.
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java
<https://reviews.apache.org/r/21760/#comment78068>
Nit: indentation.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestDatabaseProvider.java
<https://reviews.apache.org/r/21760/#comment78070>
indentation
- Sravya Tirukkovalur
On May 21, 2014, 6:33 a.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21760/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 6:33 a.m.)
>
>
> Review request for sentry and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-191
> https://issues.apache.org/jira/browse/SENTRY-191
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The diff doesn't include the thrift generated code.
> Handle the group resolution on Sentry store.
> remove the requester group from all thrift RPC definitions.
> The group mapping is set using a new config property, same Hadoop and Local group mapping support at this point
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java b6f39ad
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationProvider.java de774f4
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/HadoopGroupMappingService.java 6c8fa95
> sentry-provider/sentry-provider-db/pom.xml fca6c52
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 5f8a65f
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 8e58202
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java d06ac3c
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift a8b511d
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerWithoutKerberos.java 81a9ea4
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java 1e4ed17
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java 07352ab
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/LocalGroupMappingService.java a4d9cba
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/Context.java ce374c2
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestDatabaseProvider.java 176acee
>
> Diff: https://reviews.apache.org/r/21760/diff/
>
>
> Testing
> -------
>
> Updated the db provider test cases.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>