You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "the-other-tim-brown (via GitHub)" <gi...@apache.org> on 2025/07/22 16:04:40 UTC
Re: [PR] [HUDI-9602] Use BufferedRecordMerger for dedup and global index path [hudi]
the-other-tim-brown commented on code in PR #13588:
URL: https://github.com/apache/hudi/pull/13588#discussion_r2223056482
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/BufferedRecordMergerFactory.java:
##########
@@ -167,7 +167,10 @@ public Option<BufferedRecord<T>> deltaMerge(BufferedRecord<T> newRecord, Buffere
if (existingRecord == null || shouldKeepNewerRecord(existingRecord, newRecord)) {
return Option.of(newRecord);
}
- return Option.empty();
+ // Note that:
+ // for regular route, returning Option.empty or Option.of(existingRecord) is the same.
Review Comment:
I don't think this is true, otherwise why would we return an option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org