You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Jamie goodyear (JIRA)" <ji...@apache.org> on 2009/10/27 18:25:00 UTC
[jira] Created: (FELIX-1815) [Karaf] Introduce 'admin:disconnect'
command to allow ssh client to disconnect from karaf instances.
[Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.
----------------------------------------------------------------------------------------------------
Key: FELIX-1815
URL: https://issues.apache.org/jira/browse/FELIX-1815
Project: Felix
Issue Type: New Feature
Components: Karaf
Reporter: Jamie goodyear
Priority: Minor
[Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.
When a user connects to a running Karaf instance they generally will want to disconnect from that instance at some time. If they execure 'osgi:shutdown' they will terminate the instance runtime. Issuing a '^D' to disconnect is not consistent with other karaf commands. I would like to be able to type 'admin:disconnect' while logged into an instance and be returned to parent instance (where ever the original connect command was issued from).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1815) [Karaf] Introduce 'admin:disconnect'
command to allow ssh client to disconnect from karaf instances.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jamie goodyear updated FELIX-1815:
----------------------------------
Attachment: felix-1815.patch
File: felix-1815.patch
Contains new 'shell:logout' directive. This command is intended to allow karaf console users to logout of a running shell, without using '^D'.
I have not tackled the issue of untieing the lifecycle of the osgi framework from the lifecycle of the main shell with this patch, I've only implemented a basic 'logout' or 'exit' functionality here.
> [Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.
> ----------------------------------------------------------------------------------------------------
>
> Key: FELIX-1815
> URL: https://issues.apache.org/jira/browse/FELIX-1815
> Project: Felix
> Issue Type: New Feature
> Components: Karaf
> Reporter: Jamie goodyear
> Priority: Minor
> Attachments: felix-1815.patch
>
>
> [Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.
> When a user connects to a running Karaf instance they generally will want to disconnect from that instance at some time. If they execure 'osgi:shutdown' they will terminate the instance runtime. Issuing a '^D' to disconnect is not consistent with other karaf commands. I would like to be able to type 'admin:disconnect' while logged into an instance and be returned to parent instance (where ever the original connect command was issued from).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1815) [Karaf] Introduce 'admin:disconnect'
command to allow ssh client to disconnect from karaf instances.
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet updated FELIX-1815:
-----------------------------------
Fix Version/s: karaf-1.4.0
> [Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.
> ----------------------------------------------------------------------------------------------------
>
> Key: FELIX-1815
> URL: https://issues.apache.org/jira/browse/FELIX-1815
> Project: Felix
> Issue Type: New Feature
> Components: Karaf
> Reporter: Jamie goodyear
> Assignee: Guillaume Nodet
> Priority: Minor
> Fix For: karaf-1.4.0
>
> Attachments: felix-1815.patch
>
>
> [Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.
> When a user connects to a running Karaf instance they generally will want to disconnect from that instance at some time. If they execure 'osgi:shutdown' they will terminate the instance runtime. Issuing a '^D' to disconnect is not consistent with other karaf commands. I would like to be able to type 'admin:disconnect' while logged into an instance and be returned to parent instance (where ever the original connect command was issued from).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1815) Introduce 'shell:logout' command to
close the current shell
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet updated FELIX-1815:
-----------------------------------
Summary: Introduce 'shell:logout' command to close the current shell (was: [Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.)
> Introduce 'shell:logout' command to close the current shell
> -----------------------------------------------------------
>
> Key: FELIX-1815
> URL: https://issues.apache.org/jira/browse/FELIX-1815
> Project: Felix
> Issue Type: New Feature
> Components: Karaf
> Reporter: Jamie goodyear
> Assignee: Guillaume Nodet
> Priority: Minor
> Fix For: karaf-1.4.0
>
> Attachments: felix-1815.patch
>
>
> [Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.
> When a user connects to a running Karaf instance they generally will want to disconnect from that instance at some time. If they execure 'osgi:shutdown' they will terminate the instance runtime. Issuing a '^D' to disconnect is not consistent with other karaf commands. I would like to be able to type 'admin:disconnect' while logged into an instance and be returned to parent instance (where ever the original connect command was issued from).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-1815) [Karaf] Introduce 'admin:disconnect'
command to allow ssh client to disconnect from karaf instances.
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet reassigned FELIX-1815:
--------------------------------------
Assignee: Guillaume Nodet
> [Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.
> ----------------------------------------------------------------------------------------------------
>
> Key: FELIX-1815
> URL: https://issues.apache.org/jira/browse/FELIX-1815
> Project: Felix
> Issue Type: New Feature
> Components: Karaf
> Reporter: Jamie goodyear
> Assignee: Guillaume Nodet
> Priority: Minor
> Fix For: karaf-1.4.0
>
> Attachments: felix-1815.patch
>
>
> [Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.
> When a user connects to a running Karaf instance they generally will want to disconnect from that instance at some time. If they execure 'osgi:shutdown' they will terminate the instance runtime. Issuing a '^D' to disconnect is not consistent with other karaf commands. I would like to be able to type 'admin:disconnect' while logged into an instance and be returned to parent instance (where ever the original connect command was issued from).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1815) Introduce 'shell:logout' command to
close the current shell
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved FELIX-1815.
------------------------------------
Resolution: Fixed
Committing to https://svn.apache.org/repos/asf/felix/trunk ...
A karaf/shell/commands/src/main/java/org/apache/felix/karaf/shell/commands/LogoutAction.java
M karaf/shell/commands/src/main/java/org/apache/felix/karaf/shell/commands/MoreAction.java
M karaf/shell/commands/src/main/resources/OSGI-INF/blueprint/shell-commands.xml
A karaf/shell/console/src/main/java/org/apache/felix/karaf/shell/console/CloseShellException.java
M karaf/shell/console/src/main/java/org/apache/felix/karaf/shell/console/jline/Console.java
Committed r908230
> Introduce 'shell:logout' command to close the current shell
> -----------------------------------------------------------
>
> Key: FELIX-1815
> URL: https://issues.apache.org/jira/browse/FELIX-1815
> Project: Felix
> Issue Type: New Feature
> Components: Karaf
> Reporter: Jamie goodyear
> Assignee: Guillaume Nodet
> Priority: Minor
> Fix For: karaf-1.4.0
>
> Attachments: felix-1815.patch
>
>
> [Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.
> When a user connects to a running Karaf instance they generally will want to disconnect from that instance at some time. If they execure 'osgi:shutdown' they will terminate the instance runtime. Issuing a '^D' to disconnect is not consistent with other karaf commands. I would like to be able to type 'admin:disconnect' while logged into an instance and be returned to parent instance (where ever the original connect command was issued from).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1815) [Karaf] Introduce 'admin:disconnect'
command to allow ssh client to disconnect from karaf instances.
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782917#action_12782917 ]
Guillaume Nodet commented on FELIX-1815:
----------------------------------------
Sorry for the delay, I'm not 100% sure about this change. The interruption is kinda handled for the ^C though most commands do not really check for the interrupted flag. I need to investigate a bit more. Maybe throwing a known and specific exception could be done instead.
> [Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.
> ----------------------------------------------------------------------------------------------------
>
> Key: FELIX-1815
> URL: https://issues.apache.org/jira/browse/FELIX-1815
> Project: Felix
> Issue Type: New Feature
> Components: Karaf
> Reporter: Jamie goodyear
> Priority: Minor
> Attachments: felix-1815.patch
>
>
> [Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.
> When a user connects to a running Karaf instance they generally will want to disconnect from that instance at some time. If they execure 'osgi:shutdown' they will terminate the instance runtime. Issuing a '^D' to disconnect is not consistent with other karaf commands. I would like to be able to type 'admin:disconnect' while logged into an instance and be returned to parent instance (where ever the original connect command was issued from).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1815) [Karaf] Introduce 'admin:disconnect'
command to allow ssh client to disconnect from karaf instances.
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770612#action_12770612 ]
Guillaume Nodet commented on FELIX-1815:
----------------------------------------
I think the use of ^D is consistent: it kills the current shell. The point is that the 'main' shell which is started when launching a karaf instance is tied to the lifecycle of the osgi framework, so whenever you exit this shell, the framework will be shutdown. This is the case for the root instance and sub-instances if you launch those using bin/karaf. But this is not the case if you connect to whatever instance using a client.
I do agree with introducing a command to explicitely exit the shell, but i'd rather call it 'shell:exit' or 'shell:logout'. Another point to discuss would be to untie the lifecycle of the osgi framework from the lifecycle of the main shell (the one accessible when using bin/karaf).
Thoughts ?
> [Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.
> ----------------------------------------------------------------------------------------------------
>
> Key: FELIX-1815
> URL: https://issues.apache.org/jira/browse/FELIX-1815
> Project: Felix
> Issue Type: New Feature
> Components: Karaf
> Reporter: Jamie goodyear
> Priority: Minor
>
> [Karaf] Introduce 'admin:disconnect' command to allow ssh client to disconnect from karaf instances.
> When a user connects to a running Karaf instance they generally will want to disconnect from that instance at some time. If they execure 'osgi:shutdown' they will terminate the instance runtime. Issuing a '^D' to disconnect is not consistent with other karaf commands. I would like to be able to type 'admin:disconnect' while logged into an instance and be returned to parent instance (where ever the original connect command was issued from).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.