[GitHub] [iceberg] kbendick commented on a change in pull request #4118: Spark: Align Antlr version with Spark

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#discussion_r806207519



##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
 
     // Required because we remove antlr plugin dependencies from the compile configuration, see note above
     // We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
-    runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
-    antlr "org.antlr:antlr4:4.7.1"
+    runtimeOnly "org.antlr:antlr4-runtime:4.8"
+    antlr "org.antlr:antlr4:4.8"

Review comment:
       It seems like according to the comments in the build file that this should be shaded.
   
   I'm guessing that the two still don't play nicely together? We might want to update some of the notes about shading the antlr runtime, as the comments make it seem like we don't need to worry about version conflicts with Spark (but the issue indicates we likely do).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org