You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2021/11/16 06:48:09 UTC
[GitHub] [incubator-hop] uraychang opened a new pull request #1195: HOP-HOP-3501 : Avoid formatting hop-variables.xml
uraychang opened a new pull request #1195:
URL: https://github.com/apache/incubator-hop/pull/1195
Following this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/HOP) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[HOP-XXX] - Fixes bug in SessionManager`,
where you replace `HOP-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
If this is your first contribution, you have to read the [Contribution Guidelines](https://hop.apache.org/community/contributing/)
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] uraychang commented on pull request #1195: HOP-HOP-3501 : Avoid formatting hop-variables.xml
Posted by GitBox <gi...@apache.org>.
uraychang commented on pull request #1195:
URL: https://github.com/apache/incubator-hop/pull/1195#issuecomment-970059989
So, I just need to simply fix the hop-variables.xml file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] uraychang edited a comment on pull request #1195: HOP-HOP-3501 : Avoid formatting hop-variables.xml
Posted by GitBox <gi...@apache.org>.
uraychang edited a comment on pull request #1195:
URL: https://github.com/apache/incubator-hop/pull/1195#issuecomment-970059989
So, I just need to simply fix the description value in the hop-variables.xml file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] uraychang commented on pull request #1195: HOP-HOP-3501 : Avoid formatting hop-variables.xml
Posted by GitBox <gi...@apache.org>.
uraychang commented on pull request #1195:
URL: https://github.com/apache/incubator-hop/pull/1195#issuecomment-970094223
@hansva Updated!! thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva merged pull request #1195: HOP-HOP-3501 : Avoid formatting hop-variables.xml
Posted by GitBox <gi...@apache.org>.
hansva merged pull request #1195:
URL: https://github.com/apache/incubator-hop/pull/1195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #1195: HOP-HOP-3501 : Avoid formatting hop-variables.xml
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1195:
URL: https://github.com/apache/incubator-hop/pull/1195#issuecomment-970076393
Feel free to force push, or add an extra commit to this one reverting your previous change and adding the new changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #1195: HOP-HOP-3501 : Avoid formatting hop-variables.xml
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1195:
URL: https://github.com/apache/incubator-hop/pull/1195#issuecomment-970123547
Thanks @uraychang !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #1195: HOP-HOP-3501 : Avoid formatting hop-variables.xml
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1195:
URL: https://github.com/apache/incubator-hop/pull/1195#issuecomment-970065954
yes, I would fix the file in this case. There might be cases we want line breaks in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] uraychang commented on pull request #1195: HOP-HOP-3501 : Avoid formatting hop-variables.xml
Posted by GitBox <gi...@apache.org>.
uraychang commented on pull request #1195:
URL: https://github.com/apache/incubator-hop/pull/1195#issuecomment-970072349
@hansva usually what's the best way to revise the PR?
force push to update this PR or just close it and reopen another one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #1195: HOP-HOP-3501 : Avoid formatting hop-variables.xml
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1195:
URL: https://github.com/apache/incubator-hop/pull/1195#issuecomment-969967503
Hi @uraychang , I don't think we should do this.
We should just fix the file containing the variables. This was introduced by using a code formatter on all files.
We no longer do this by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org