[jira] [Commented] (HIVE-18050) LlapServiceDriver shoud split HIVE_AUX_JARS_PATH by ':' instead of ','

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-18050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249376#comment-16249376 ] 

ASF GitHub Bot commented on HIVE-18050:
---------------------------------------

GitHub user Aegeaner opened a pull request:

    https://github.com/apache/hive/pull/271

    HIVE-18050: LlapServiceDriver shoud split HIVE_AUX_JARS_PATH by ':' i…

    LlapServiceDriver shoud split HIVE_AUX_JARS_PATH by ':' instead of ','
    
    https://issues.apache.org/jira/browse/HIVE-18050


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Aegeaner/hive HIVE-18050

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hive/pull/271.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #271
    
----
commit 468be0a68cfc7cb5fdc4357ecd8f0001bfe7ec7c
Author: Aegeaner <xi...@gmail.com>
Date:   2017-11-13T10:49:23Z

    HIVE-18050: LlapServiceDriver shoud split HIVE_AUX_JARS_PATH by ':' instead of ','

----


> LlapServiceDriver shoud split HIVE_AUX_JARS_PATH by ':' instead of ','
> ----------------------------------------------------------------------
>
>                 Key: HIVE-18050
>                 URL: https://issues.apache.org/jira/browse/HIVE-18050
>             Project: Hive
>          Issue Type: Bug
>          Components: CLI, Clients
>    Affects Versions: 2.3.0
>            Reporter: Aegeaner
>            Assignee: Aegeaner
>              Labels: pull-request-available
>
> LlapServiceDriver shoud split HIVE_AUX_JARS_PATH by ':' instead of ',' , since in hive script the environment variable has been replaced:
> {code:java}
> elif [ "${HIVE_AUX_JARS_PATH}" != "" ]; then 
>   HIVE_AUX_JARS_PATH=`echo $HIVE_AUX_JARS_PATH | sed 's/,/:/g'`
>   if $cygwin; then
>       HIVE_AUX_JARS_PATH=`cygpath -p -w "$HIVE_AUX_JARS_PATH"`
>       HIVE_AUX_JARS_PATH=`echo $HIVE_AUX_JARS_PATH | sed 's/;/,/g'`
>   fi
>   AUX_CLASSPATH=${AUX_CLASSPATH}:${HIVE_AUX_JARS_PATH}
>   AUX_PARAM="file://$(echo ${HIVE_AUX_JARS_PATH} | sed 's/:/,file:\/\//g')"
> fi
> {code}
> But in the LLAP Service Driver, it's processed as :
> {code:java}
>  private void addAuxJarsToSet(HashSet<String> auxJarSet, String auxJars) {
>           if (auxJars != null && !auxJars.isEmpty()) {
>             // TODO: transitive dependencies warning?
>             String[] jarPaths = auxJars.split(",");
>             for (String jarPath : jarPaths) {
>               if (!jarPath.isEmpty()) {
>                 auxJarSet.add(jarPath);
>               }
>             }
>           }
>         }
>       };
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)