You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/25 12:53:09 UTC

[GitHub] [pulsar] lhotari opened a new pull request #10365: Fix flaky ManagedLedgerImpl shutdown

lhotari opened a new pull request #10365:
URL: https://github.com/apache/pulsar/pull/10365


   Fixes #10356 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #10365: Fix flaky ManagedLedgerFactory shutdown

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10365:
URL: https://github.com/apache/pulsar/pull/10365


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10365: Fix flaky ManagedLedgerImpl shutdown

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10365:
URL: https://github.com/apache/pulsar/pull/10365#issuecomment-826320071






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10365: Fix flaky ManagedLedgerImpl shutdown

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10365:
URL: https://github.com/apache/pulsar/pull/10365#issuecomment-826320071


   @codelipenghui @eolivelli @congbobo184 @merlimat Please review. This fixes the flakiness issue in master branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10365: Fix flaky ManagedLedgerImpl shutdown and fix NPE in load balancer task at shutdown

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10365:
URL: https://github.com/apache/pulsar/pull/10365#issuecomment-826337918


   > Looks good.
   > I wasn't sure about the 'possible race conditions' that may happen during shutdown.
   
   Yes ledgers map changed asynchronously (that's the race condition) and this caused the shutdown to wait forever. The stacktrace in the issue helps understand it.
   
   > 
   > Also, the title is not only about ManagedLedgerFactory, can you please correct it?
   
   Updated
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #10365: Fix flaky ManagedLedgerFactory shutdown

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10365:
URL: https://github.com/apache/pulsar/pull/10365


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10365: Fix flaky ManagedLedgerImpl shutdown

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10365:
URL: https://github.com/apache/pulsar/pull/10365#issuecomment-826326080


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10365: Fix flaky ManagedLedgerImpl shutdown

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10365:
URL: https://github.com/apache/pulsar/pull/10365#issuecomment-826326080


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10365: Fix flaky ManagedLedgerImpl shutdown

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10365:
URL: https://github.com/apache/pulsar/pull/10365#issuecomment-826326080


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org