You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by Michael Osipov <mi...@apache.org> on 2024/02/18 12:45:22 UTC
[VOTE] Release Velocity Engine version 2.4.1
Hi,
Release notes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310104&version=12354231
Staging repo:
https://repository.apache.org/content/repositories/orgapachevelocity-1043/
https://repository.apache.org/content/repositories/orgapachevelocity-1043/org/apache/velocity/velocity-engine-parent/2.4.1/velocity-engine-parent-2.4.1-source-release.zip
Source release checksum(s):
velocity-engine-parent-2.4.1-source-release.zip
sha512:
140854cf8e2a1f315b954d8be8c56f0087a13ec647065ecdea3594d2cb0099414fede608a2a9392f15beb04e6fb89b220710d0032b9bd734113e6bf578550187
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Engine version 2.4.1
Posted by Michael Osipov <mi...@apache.org>.
On 2024/02/21 11:54:51 Claude Brisson wrote:
> > I use this one [1] sans the part which does not apply to Velocity TLP to comply with ASF release requirements. If there is a documentation for the Velocity project which does not have more manual steps compared to the [1], I will happily do it, but I don't want to waste my time for unnecessary juggling. I rather invest it in making the code base better. [1] works very well for the entire Maven ecosystem and is followed by Maven devs, I don't see why I cannot apply to ther ASF Java-centric TLPs.
> >
> > Please note that the entire Maven Site Plugin ecosystem relies on Velocity Engine and Tools, so this is why I want to move this one forward and in greater for the entire OSS community.
> >
> > Michael
> >
> > [1]https://maven.apache.org/developers/release/maven-project-release-procedure.html
>
> We have our release process page [2].
>
> [2] https://velocity.apache.org/release-process.html
Thanks, Claude! I wasn't aware of that. Quite eloborate and I can see that I hav a few shortcomings (keys, Javadoc, site, etc), but I can also see that includes steps which make it unnecessarily complex. E.g.,
* Fiddling with "git revert", "git tag"
* Calculating checksums for files which no one needs in dist (e.g. POM) also ASF rules only require source tarball
Regards,
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Engine version 2.4.1
Posted by Claude Brisson <cl...@renegat.net.INVALID>.
> I use this one [1] sans the part which does not apply to Velocity TLP to comply with ASF release requirements. If there is a documentation for the Velocity project which does not have more manual steps compared to the [1], I will happily do it, but I don't want to waste my time for unnecessary juggling. I rather invest it in making the code base better. [1] works very well for the entire Maven ecosystem and is followed by Maven devs, I don't see why I cannot apply to ther ASF Java-centric TLPs.
>
> Please note that the entire Maven Site Plugin ecosystem relies on Velocity Engine and Tools, so this is why I want to move this one forward and in greater for the entire OSS community.
>
> Michael
>
> [1]https://maven.apache.org/developers/release/maven-project-release-procedure.html
We have our release process page [2].
[2] https://velocity.apache.org/release-process.html
Re: [VOTE] Release Velocity Engine version 2.4.1
Posted by Michael Osipov <mi...@apache.org>.
On 2024/02/19 21:12:39 Claude Brisson wrote:
> On 19/02/2024 21:34, Michael Osipov wrote:
>
> > On 2024/02/19 20:25:45 Claude Brisson wrote:
> >> Version numbers are advertized and are supposed to be coherent. We don't
> >> care that the tags are public, they are not advertized. I didn't say
> >> that you had to reuse the tag. The tag can be named 2.4-RC2. You don't
> >> have to rename anything, or did I miss something?
> > I cannot follow. What am I supported to do with 2.4-RC2? I cannot supply this to Maven Release Plugin otherwise it will bein the POM and in the repo. This is already on master and shouldn't appear again: https://github.com/apache/velocity-engine/commit/5d9e48ca0f1776300f1cf07199eb79c34dbe9cb7
> >
> > Git tag and version in POM have to be consistent.
>
> They are supposed to be consistent, that's why the tag you put to call
> the vote should be in the form 2.4-RCx. Otherwise, there would be a hole
> in the versioning each time there is a failed vote. Because the RC tag
> was named 2.4, you cannot reuse it, so let's use another tag, it's not a
> big deal.
>
> I don't understand the point with the maven plugin. The plugin -or its
> use- has to adapt to the chosen versioning, not the opposite.
>
> > I don't see how this can be achieved.
>
> I'm sure that there's a way of doing it. If not, you can still erase the
> 2.4 tag, after all. I mean, releasing the 2.4.1 *without* having
> released the 2.4 is... weird. There must be a way.
>
> > Moreover, that version needs to land as source release zip on ASF dist area. The zip content cannot be x-RCy.
>
> On that, we agree. The RC life span *is* the vote.
I use this one [1] sans the part which does not apply to Velocity TLP to comply with ASF release requirements. If there is a documentation for the Velocity project which does not have more manual steps compared to the [1], I will happily do it, but I don't want to waste my time for unnecessary juggling. I rather invest it in making the code base better. [1] works very well for the entire Maven ecosystem and is followed by Maven devs, I don't see why I cannot apply to ther ASF Java-centric TLPs.
Please note that the entire Maven Site Plugin ecosystem relies on Velocity Engine and Tools, so this is why I want to move this one forward and in greater for the entire OSS community.
Michael
[1] https://maven.apache.org/developers/release/maven-project-release-procedure.html
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Engine version 2.4.1
Posted by Claude Brisson <cl...@renegat.net.INVALID>.
On 19/02/2024 21:34, Michael Osipov wrote:
> On 2024/02/19 20:25:45 Claude Brisson wrote:
>> Version numbers are advertized and are supposed to be coherent. We don't
>> care that the tags are public, they are not advertized. I didn't say
>> that you had to reuse the tag. The tag can be named 2.4-RC2. You don't
>> have to rename anything, or did I miss something?
> I cannot follow. What am I supported to do with 2.4-RC2? I cannot supply this to Maven Release Plugin otherwise it will bein the POM and in the repo. This is already on master and shouldn't appear again: https://github.com/apache/velocity-engine/commit/5d9e48ca0f1776300f1cf07199eb79c34dbe9cb7
>
> Git tag and version in POM have to be consistent.
They are supposed to be consistent, that's why the tag you put to call
the vote should be in the form 2.4-RCx. Otherwise, there would be a hole
in the versioning each time there is a failed vote. Because the RC tag
was named 2.4, you cannot reuse it, so let's use another tag, it's not a
big deal.
I don't understand the point with the maven plugin. The plugin -or its
use- has to adapt to the chosen versioning, not the opposite.
> I don't see how this can be achieved.
I'm sure that there's a way of doing it. If not, you can still erase the
2.4 tag, after all. I mean, releasing the 2.4.1 *without* having
released the 2.4 is... weird. There must be a way.
> Moreover, that version needs to land as source release zip on ASF dist area. The zip content cannot be x-RCy.
On that, we agree. The RC life span *is* the vote.
Claude
>
> I guess I miss here something as well.
>
> Michael
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> For additional commands, e-mail: dev-help@velocity.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Engine version 2.4.1
Posted by Michael Osipov <mi...@apache.org>.
On 2024/02/19 20:25:45 Claude Brisson wrote:
> Version numbers are advertized and are supposed to be coherent. We don't
> care that the tags are public, they are not advertized. I didn't say
> that you had to reuse the tag. The tag can be named 2.4-RC2. You don't
> have to rename anything, or did I miss something?
I cannot follow. What am I supported to do with 2.4-RC2? I cannot supply this to Maven Release Plugin otherwise it will bein the POM and in the repo. This is already on master and shouldn't appear again: https://github.com/apache/velocity-engine/commit/5d9e48ca0f1776300f1cf07199eb79c34dbe9cb7
Git tag and version in POM have to be consistent. I don't see how this can be achieved. Moreover, that version needs to land as source release zip on ASF dist area. The zip content cannot be x-RCy.
I guess I miss here something as well.
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Engine version 2.4.1
Posted by Claude Brisson <cl...@renegat.net.INVALID>.
Version numbers are advertized and are supposed to be coherent. We don't
care that the tags are public, they are not advertized. I didn't say
that you had to reuse the tag. The tag can be named 2.4-RC2. You don't
have to rename anything, or did I miss something?
Claude
On 18/02/2024 23:06, Michael Osipov wrote:
> There are several issues with reusing tags and why this is wrong:
>
> * Versions are cheap
> * As soon as a tag is pushed it is replicated (public), changing the tag would break public
> * Git log would show the same version twice on master: does not make sense
> * Building the two tags with the same version would yield a different result
> * Fiddling in the repo to rename something is unnecessary manual work for me
> * Failed version is marked as archived, visible that it didn't make it
>
> It Maven land we simply burn version because it is honest and straight forward. Doing additional manual steps for tens of components does not really work.
>
> Michael
>
> On 2024/02/18 15:28:11 Claude Brisson wrote:
>> The previous "2.4" was just a PR, so why would we jump to 2.4.1 for the
>> version ? It's a minor annoyance if you cannot reuse the tag 2.4, just
>> name the tag 2.4-final or something like that, no? It's more annoying if
>> there is a phantom 2.4 version number which has not been release, IMO.
>>
>> On 18/02/2024 13:45, Michael Osipov wrote:
>>> Hi,
>>>
>>> Release notes:
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310104&version=12354231
>>>
>>> Staging repo:
>>> https://repository.apache.org/content/repositories/orgapachevelocity-1043/
>>>
>>> https://repository.apache.org/content/repositories/orgapachevelocity-1043/org/apache/velocity/velocity-engine-parent/2.4.1/velocity-engine-parent-2.4.1-source-release.zip
>>>
>>>
>>> Source release checksum(s):
>>> velocity-engine-parent-2.4.1-source-release.zip
>>> sha512:
>>> 140854cf8e2a1f315b954d8be8c56f0087a13ec647065ecdea3594d2cb0099414fede608a2a9392f15beb04e6fb89b220710d0032b9bd734113e6bf578550187
>>>
>>> Vote open for 72 hours.
>>>
>>> [ ] +1
>>> [ ] +0
>>> [ ] -1
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
>>> For additional commands, e-mail: dev-help@velocity.apache.org
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
>> For additional commands, e-mail: dev-help@velocity.apache.org
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> For additional commands, e-mail: dev-help@velocity.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Engine version 2.4.1
Posted by Michael Osipov <mi...@apache.org>.
There are several issues with reusing tags and why this is wrong:
* Versions are cheap
* As soon as a tag is pushed it is replicated (public), changing the tag would break public
* Git log would show the same version twice on master: does not make sense
* Building the two tags with the same version would yield a different result
* Fiddling in the repo to rename something is unnecessary manual work for me
* Failed version is marked as archived, visible that it didn't make it
It Maven land we simply burn version because it is honest and straight forward. Doing additional manual steps for tens of components does not really work.
Michael
On 2024/02/18 15:28:11 Claude Brisson wrote:
> The previous "2.4" was just a PR, so why would we jump to 2.4.1 for the
> version ? It's a minor annoyance if you cannot reuse the tag 2.4, just
> name the tag 2.4-final or something like that, no? It's more annoying if
> there is a phantom 2.4 version number which has not been release, IMO.
>
> On 18/02/2024 13:45, Michael Osipov wrote:
> > Hi,
> >
> > Release notes:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310104&version=12354231
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/orgapachevelocity-1043/
> >
> > https://repository.apache.org/content/repositories/orgapachevelocity-1043/org/apache/velocity/velocity-engine-parent/2.4.1/velocity-engine-parent-2.4.1-source-release.zip
> >
> >
> > Source release checksum(s):
> > velocity-engine-parent-2.4.1-source-release.zip
> > sha512:
> > 140854cf8e2a1f315b954d8be8c56f0087a13ec647065ecdea3594d2cb0099414fede608a2a9392f15beb04e6fb89b220710d0032b9bd734113e6bf578550187
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> > For additional commands, e-mail: dev-help@velocity.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> For additional commands, e-mail: dev-help@velocity.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Engine version 2.4.1
Posted by Claude Brisson <cl...@renegat.net.INVALID>.
The previous "2.4" was just a PR, so why would we jump to 2.4.1 for the
version ? It's a minor annoyance if you cannot reuse the tag 2.4, just
name the tag 2.4-final or something like that, no? It's more annoying if
there is a phantom 2.4 version number which has not been release, IMO.
On 18/02/2024 13:45, Michael Osipov wrote:
> Hi,
>
> Release notes:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310104&version=12354231
>
> Staging repo:
> https://repository.apache.org/content/repositories/orgapachevelocity-1043/
>
> https://repository.apache.org/content/repositories/orgapachevelocity-1043/org/apache/velocity/velocity-engine-parent/2.4.1/velocity-engine-parent-2.4.1-source-release.zip
>
>
> Source release checksum(s):
> velocity-engine-parent-2.4.1-source-release.zip
> sha512:
> 140854cf8e2a1f315b954d8be8c56f0087a13ec647065ecdea3594d2cb0099414fede608a2a9392f15beb04e6fb89b220710d0032b9bd734113e6bf578550187
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> For additional commands, e-mail: dev-help@velocity.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[CANCELED] [VOTE] Release Velocity Engine version 2.4.1
Posted by Michael Osipov <mi...@apache.org>.
Canceling the vote and dropping the release. It did not reach the
required quorum.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Engine version 2.4.1
Posted by Michael Osipov <mi...@apache.org>.
+1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Engine version 2.4.1
Posted by Greg Huber <gr...@gmail.com>.
It passes all my tests, and works great. Thanks.
On 18/02/2024 12:45, Michael Osipov wrote:
> Hi,
>
> Release notes:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310104&version=12354231
>
> Staging repo:
> https://repository.apache.org/content/repositories/orgapachevelocity-1043/
>
> https://repository.apache.org/content/repositories/orgapachevelocity-1043/org/apache/velocity/velocity-engine-parent/2.4.1/velocity-engine-parent-2.4.1-source-release.zip
>
>
> Source release checksum(s):
> velocity-engine-parent-2.4.1-source-release.zip
> sha512:
> 140854cf8e2a1f315b954d8be8c56f0087a13ec647065ecdea3594d2cb0099414fede608a2a9392f15beb04e6fb89b220710d0032b9bd734113e6bf578550187
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> For additional commands, e-mail: dev-help@velocity.apache.org
>
Re: [VOTE] Release Velocity Engine version 2.4.1
Posted by Michael Osipov <mi...@apache.org>.
Guys, please note that the vote ends today. If you intend to vote, vote today.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org