You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/04/09 00:22:58 UTC
Review Request 20139: Move OOM log message to appear only on actual OOM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20139/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
Description
-------
Move OOM log message to appear only on actual OOM.
It is confusing to see "OOM notifier is triggered..." logged when it's often just being discarded.
Diffs
-----
src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
Diff: https://reviews.apache.org/r/20139/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 20139: Move OOM log message to appear only on actual OOM
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20139/#review39883
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20139]
All tests passed.
- Mesos ReviewBot
On April 8, 2014, 10:45 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20139/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 10:45 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1100
> https://issues.apache.org/jira/browse/MESOS-1100
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Move OOM log message to appear only on actual OOM.
>
> It is confusing to see "OOM notifier is triggered..." logged when it's often just being discarded.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
>
> Diff: https://reviews.apache.org/r/20139/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20139: Move OOM log message to appear only on actual OOM
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20139/
-----------------------------------------------------------
(Updated April 8, 2014, 10:45 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
added bug link
Bugs: MESOS-1100
https://issues.apache.org/jira/browse/MESOS-1100
Repository: mesos-git
Description
-------
Move OOM log message to appear only on actual OOM.
It is confusing to see "OOM notifier is triggered..." logged when it's often just being discarded.
Diffs
-----
src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
Diff: https://reviews.apache.org/r/20139/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 20139: Move OOM log message to appear only on actual OOM
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20139/
-----------------------------------------------------------
(Updated April 8, 2014, 10:44 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
joined comment to single line
Repository: mesos-git
Description
-------
Move OOM log message to appear only on actual OOM.
It is confusing to see "OOM notifier is triggered..." logged when it's often just being discarded.
Diffs (updated)
-----
src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
Diff: https://reviews.apache.org/r/20139/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 20139: Move OOM log message to appear only on actual OOM
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20139/#review39832
-----------------------------------------------------------
Ship it!
Thanks, please include and update MESOS-1100.
src/slave/containerizer/isolators/cgroups/mem.cpp
<https://reviews.apache.org/r/20139/#comment72507>
This fits on one line :)
- Ben Mahler
On April 8, 2014, 10:22 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20139/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 10:22 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Move OOM log message to appear only on actual OOM.
>
> It is confusing to see "OOM notifier is triggered..." logged when it's often just being discarded.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
>
> Diff: https://reviews.apache.org/r/20139/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>