You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by necouchman <gi...@git.apache.org> on 2017/05/31 12:59:49 UTC
[GitHub] incubator-guacamole-client pull request #160: GUACAMOLE-203: Add support for...
GitHub user necouchman opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/160
GUACAMOLE-203: Add support for SSH Keep Alive
This is for the minor changes required on the client side to support configuring the SSH Keep Alive interval for SSH connections.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/necouchman/incubator-guacamole-client GUACAMOLE-203
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #160
----
commit 5e9c2c668960073926caf63d1518dbad0a6eda3f
Author: Nick Couchman <vn...@apache.org>
Date: 2017-05-31T12:27:07Z
GUACAMOLE-203: Add support for configuring the server-alive-interval SSH parameter.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #160: GUACAMOLE-203: Add support for...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/160#discussion_r123908626
--- Diff: guacamole/src/main/webapp/translations/en.json ---
@@ -531,6 +533,7 @@
"FIELD_HEADER_RECORDING_PATH" : "Recording path:",
"FIELD_HEADER_SFTP_DIRECTORY" : "Default upload directory:",
"FIELD_HEADER_SFTP_HOSTNAME" : "Hostname:",
+ "FIELD_HEADER_SFTP_KEEPALIVE" : "SFTP Keepalive Interval:",
--- End diff --
Fixed, x2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #160: GUACAMOLE-203: Add support for...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/160#discussion_r123908459
--- Diff: guacamole/src/main/webapp/translations/en.json ---
@@ -531,6 +533,7 @@
"FIELD_HEADER_RECORDING_PATH" : "Recording path:",
"FIELD_HEADER_SFTP_DIRECTORY" : "Default upload directory:",
"FIELD_HEADER_SFTP_HOSTNAME" : "Hostname:",
+ "FIELD_HEADER_SFTP_KEEPALIVE" : "SFTP Keepalive Interval:",
--- End diff --
`FIELD_HEADER_SFTP_KEEPALIVE` will not work, as the parameter has been renamed to `sftp-server-alive-interval`. This will need to be changed to `FIELD_HEADER_SFTP_SERVER_ALIVE_INTERVAL`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #160: GUACAMOLE-203: Add support for...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-client/pull/160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #160: GUACAMOLE-203: Add support for...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/160#discussion_r123908431
--- Diff: guacamole/src/main/webapp/translations/en.json ---
@@ -355,6 +355,7 @@
"FIELD_HEADER_SERVER_LAYOUT" : "Keyboard layout:",
"FIELD_HEADER_SFTP_DIRECTORY" : "Default upload directory:",
"FIELD_HEADER_SFTP_HOSTNAME" : "Hostname:",
+ "FIELD_HEADER_SFTP_KEEPALIVE" : "SFTP Keepalive Interval:",
--- End diff --
For consistency's sake, the field headers should be sentence case, not title case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #160: GUACAMOLE-203: Add support for...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/160#discussion_r123908624
--- Diff: guacamole/src/main/webapp/translations/en.json ---
@@ -355,6 +355,7 @@
"FIELD_HEADER_SERVER_LAYOUT" : "Keyboard layout:",
"FIELD_HEADER_SFTP_DIRECTORY" : "Default upload directory:",
"FIELD_HEADER_SFTP_HOSTNAME" : "Hostname:",
+ "FIELD_HEADER_SFTP_KEEPALIVE" : "SFTP Keepalive Interval:",
--- End diff --
Corrected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---