You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by as...@apache.org on 2017/10/17 18:21:23 UTC
qpid-proton git commit: PROTON-1611: Always enable building C++
binding - There is no proper way to discover if there is a C++ compiler
except enable_language(CXX) which has no way to fail and allow the rest of
the build to carry on.
Repository: qpid-proton
Updated Branches:
refs/heads/master 0c992c984 -> ab97f488a
PROTON-1611: Always enable building C++ binding
- There is no proper way to discover if there is a C++ compiler except
enable_language(CXX) which has no way to fail and allow the rest of the
build to carry on.
Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/ab97f488
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/ab97f488
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/ab97f488
Branch: refs/heads/master
Commit: ab97f488a3690afa36852602f3b91da7752ea56f
Parents: 0c992c9
Author: Andrew Stitcher <as...@apache.org>
Authored: Tue Oct 17 14:19:33 2017 -0400
Committer: Andrew Stitcher <as...@apache.org>
Committed: Tue Oct 17 14:19:33 2017 -0400
----------------------------------------------------------------------
proton-c/bindings/CMakeLists.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/ab97f488/proton-c/bindings/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/proton-c/bindings/CMakeLists.txt b/proton-c/bindings/CMakeLists.txt
index a8dbe57..9a431d7 100644
--- a/proton-c/bindings/CMakeLists.txt
+++ b/proton-c/bindings/CMakeLists.txt
@@ -31,10 +31,10 @@ if (EMSCRIPTEN_FOUND)
set (DEFAULT_JAVASCRIPT ON)
endif (EMSCRIPTEN_FOUND)
-# Prerequisites for C++
-if (CMAKE_CXX_COMPILER)
- set (DEFAULT_CPP ON)
-endif (CMAKE_CXX_COMPILER)
+# It is impossible to easily test for the presence of a C++ compiler! so set this on by default
+# That is because the OPTIONAL attribute to enable_language() does nothing (as of CMake 3.9.1)
+# so if C++ is not present the build will fail anyway!
+set (DEFAULT_CPP ON)
# Prerequisites for Go
find_program(GO_EXE go)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org