[GitHub] [beam] yyy1000 commented on a diff in pull request #25203: Fix interface{} in iter& emit type of DoFn in Go

["yyy1000 (via GitHub)" <gi...@apache.org>]

yyy1000 commented on code in PR #25203:
URL: https://github.com/apache/beam/pull/25203#discussion_r1102187994


##########
sdks/go/pkg/beam/core/funcx/output.go:
##########
@@ -84,8 +84,9 @@ func unfoldEmit(t reflect.Type) ([]reflect.Type, bool, error) {
 		if ok, err := isInParam(t.In(i)); !ok {
 			return nil, false, errors.Wrap(err, errIllegalParametersInEmit)
 		}
-		if t.In(i).Kind() == reflect.Interface || (t.In(i).Kind() == reflect.Pointer && t.In(i).Elem().Kind() == reflect.Interface) {
-			panic("Type interface{} isn't a supported PCollection type")
+		emptyInterface := reflect.TypeOf((*any)(nil)).Elem()

Review Comment:
   Oh, got it! Thanks! I changed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org