[GitHub] [arrow-rs] jhorstmann commented on a diff in pull request #1589: Fix Null Mask Handling in ArrayData And UnionArray

[GitBox <gi...@apache.org>]

jhorstmann commented on code in PR #1589:
URL: https://github.com/apache/arrow-rs/pull/1589#discussion_r856871037


##########
arrow/src/array/equal/structure.rs:
##########
@@ -84,7 +63,7 @@ pub(super) fn struct_equal(
 
             lhs_is_null
                 || (lhs_is_null == rhs_is_null)
-                    && equal_values(lhs, rhs, lhs_nulls, rhs_nulls, lhs_pos, rhs_pos, 1)
+                    && equal_child_values(lhs, rhs, lhs_pos, rhs_pos, 1)

Review Comment:
   I think this needs the same logic as for list arrays:
   
   ```suggestion
               if lhs_is_null != rhs_is_null {
                   return false;
               }
   
               lhs_is_null || equal_child_values(lhs, rhs, lhs_pos, rhs_pos, 1)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org