[GitHub] [flink] dmvk commented on a diff in pull request #19304: [FLINK-26957][runtime] Removes flush in FileSystemJobResultStore.createDirtyResultInternal

[GitBox <gi...@apache.org>]

dmvk commented on code in PR #19304:
URL: https://github.com/apache/flink/pull/19304#discussion_r841664758


##########
flink-core/src/test/java/org/apache/flink/core/fs/FileSystemBehaviorTestSuite.java:
##########
@@ -263,6 +266,21 @@ public void testMkdirsFailsWithExistingParentFile() throws Exception {
         }
     }
 
+    /**
+     * This test is added to make sure that each FileSystem's OutputStream implementation is
+     * repeatedly closable. This was necessary due to the fact that {@link
+     * ObjectMapper#writeValue(java.io.OutputStream, Object)} closes the {@link OutputStream}
+     * internally (see FLINK-26957 for more context).
+     */
+    @Test
+    public void testClosingOutputStreamTwice() throws Exception {

Review Comment:
   do we still need this test, if we're not double-closing the resource anymore?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org