You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Zhao Yongming (Created) (JIRA)" <ji...@apache.org> on 2011/10/21 08:22:33 UTC
[jira] [Created] (TS-994) X-Forwarded-For should follow the squid
way
X-Forwarded-For should follow the squid way
-------------------------------------------
Key: TS-994
URL: https://issues.apache.org/jira/browse/TS-994
Project: Traffic Server
Issue Type: Improvement
Components: HTTP
Affects Versions: 3.1.1
Reporter: Zhao Yongming
Assignee: Zhao Yongming
Priority: Minor
Fix For: 3.1.1
Attachments: XFF.patch
TS will append the IP in the format of:
X-Forwarded-For: 127.0.0.1, 10.32.102.41\r\n
while http://en.wikipedia.org/wiki/X-Forwarded-For says:
X-Forwarded-For: client1, proxy1, proxy2
there is 2 spaces
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-994) X-Forwarded-For should follow the squid
way
Posted by "Zhao Yongming (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhao Yongming updated TS-994:
-----------------------------
Description:
TS will append the IP in the format of:
{code}
X-Forwarded-For: 127.0.0.1, 10.32.102.41\r\n
{code}
while http://en.wikipedia.org/wiki/X-Forwarded-For says:
{code}
X-Forwarded-For: client1, proxy1, proxy2
{code}
there is 2 spaces in TS X-Forwarded-For header.
was:
TS will append the IP in the format of:
X-Forwarded-For: 127.0.0.1, 10.32.102.41\r\n
while http://en.wikipedia.org/wiki/X-Forwarded-For says:
X-Forwarded-For: client1, proxy1, proxy2
there is 2 spaces
> X-Forwarded-For should follow the squid way
> -------------------------------------------
>
> Key: TS-994
> URL: https://issues.apache.org/jira/browse/TS-994
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
> Affects Versions: 3.1.1
> Reporter: Zhao Yongming
> Assignee: Zhao Yongming
> Priority: Minor
> Fix For: 3.1.1
>
> Attachments: XFF.patch
>
>
> TS will append the IP in the format of:
> {code}
> X-Forwarded-For: 127.0.0.1, 10.32.102.41\r\n
> {code}
> while http://en.wikipedia.org/wiki/X-Forwarded-For says:
> {code}
> X-Forwarded-For: client1, proxy1, proxy2
> {code}
> there is 2 spaces in TS X-Forwarded-For header.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-994) X-Forwarded-For should follow the squid
way
Posted by "Igor Galić (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132484#comment-13132484 ]
Igor Galić commented on TS-994:
-------------------------------
Does this cause an actual problem anywhere or are we just talking about aesthetics?
> X-Forwarded-For should follow the squid way
> -------------------------------------------
>
> Key: TS-994
> URL: https://issues.apache.org/jira/browse/TS-994
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
> Affects Versions: 3.1.1
> Reporter: Zhao Yongming
> Assignee: Zhao Yongming
> Priority: Minor
> Fix For: 3.1.1
>
> Attachments: XFF.patch
>
>
> TS will append the IP in the format of:
> {code}
> X-Forwarded-For: 127.0.0.1, 10.32.102.41\r\n
> {code}
> while http://en.wikipedia.org/wiki/X-Forwarded-For says:
> {code}
> X-Forwarded-For: client1, proxy1, proxy2
> {code}
> there is 2 spaces in TS X-Forwarded-For header.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TS-994) X-Forwarded-For should follow the squid
way
Posted by "Zhao Yongming (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhao Yongming closed TS-994.
----------------------------
Resolution: Fixed
> X-Forwarded-For should follow the squid way
> -------------------------------------------
>
> Key: TS-994
> URL: https://issues.apache.org/jira/browse/TS-994
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
> Affects Versions: 3.1.1
> Reporter: Zhao Yongming
> Assignee: Zhao Yongming
> Priority: Minor
> Fix For: 3.1.1
>
> Attachments: XFF.patch
>
>
> TS will append the IP in the format of:
> {code}
> X-Forwarded-For: 127.0.0.1, 10.32.102.41\r\n
> {code}
> while http://en.wikipedia.org/wiki/X-Forwarded-For says:
> {code}
> X-Forwarded-For: client1, proxy1, proxy2
> {code}
> there is 2 spaces in TS X-Forwarded-For header.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-994) X-Forwarded-For should follow the squid
way
Posted by "Conan Wang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132497#comment-13132497 ]
Conan Wang commented on TS-994:
-------------------------------
My backend server will log X-Forwarded-For, and the additional leading space bother me when parsing the log.
> X-Forwarded-For should follow the squid way
> -------------------------------------------
>
> Key: TS-994
> URL: https://issues.apache.org/jira/browse/TS-994
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
> Affects Versions: 3.1.1
> Reporter: Zhao Yongming
> Assignee: Zhao Yongming
> Priority: Minor
> Fix For: 3.1.1
>
> Attachments: XFF.patch
>
>
> TS will append the IP in the format of:
> {code}
> X-Forwarded-For: 127.0.0.1, 10.32.102.41\r\n
> {code}
> while http://en.wikipedia.org/wiki/X-Forwarded-For says:
> {code}
> X-Forwarded-For: client1, proxy1, proxy2
> {code}
> there is 2 spaces in TS X-Forwarded-For header.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-994) X-Forwarded-For should follow the squid
way
Posted by "Zhao Yongming (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhao Yongming updated TS-994:
-----------------------------
Attachment: XFF.patch
a quick fix
> X-Forwarded-For should follow the squid way
> -------------------------------------------
>
> Key: TS-994
> URL: https://issues.apache.org/jira/browse/TS-994
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
> Affects Versions: 3.1.1
> Reporter: Zhao Yongming
> Assignee: Zhao Yongming
> Priority: Minor
> Fix For: 3.1.1
>
> Attachments: XFF.patch
>
>
> TS will append the IP in the format of:
> X-Forwarded-For: 127.0.0.1, 10.32.102.41\r\n
> while http://en.wikipedia.org/wiki/X-Forwarded-For says:
> X-Forwarded-For: client1, proxy1, proxy2
> there is 2 spaces
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira