[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20589: [v1.x][BUGFIX][ONEDNN] Remove next_impl calls from deconvolution

[GitBox <gi...@apache.org>]

bartekkuncer commented on a change in pull request #20589:
URL: https://github.com/apache/incubator-mxnet/pull/20589#discussion_r719178441



##########
File path: src/operator/nn/mkldnn/mkldnn_deconvolution.cc
##########
@@ -83,14 +83,12 @@ std::shared_ptr<deconv_fwd_pd_t> MKLDNNDeconvFwd::CreatePrimitiveDesc(
   const auto get_out_size     = [&pd]() { return pd->dst_desc().get_size(); };
 
   while (!ddc.CheckImplSizeReq(get_data_size(), get_weights_size(), get_out_size())) {

Review comment:
       while -> if?

##########
File path: src/operator/nn/mkldnn/mkldnn_deconvolution.cc
##########
@@ -222,14 +220,12 @@ std::shared_ptr<deconv_bwd_data_pd_t> MKLDNNDeconvBwd::CreateDataPrimitiveDesc(
   const auto get_out_size     = [&pd]() { return pd->diff_dst_desc().get_size(); };
 
   while (!ddc.CheckImplSizeReq(get_data_size(), get_weights_size(), get_out_size())) {

Review comment:
       while -> if?

##########
File path: src/operator/nn/mkldnn/mkldnn_deconvolution.cc
##########
@@ -248,14 +244,12 @@ std::shared_ptr<deconv_bwd_weights_pd_t> MKLDNNDeconvBwd::CreateWeightsPrimitive
   const auto get_out_size     = [&pd]() { return pd->diff_dst_desc().get_size(); };
 
   while (!ddc.CheckImplSizeReq(get_data_size(), get_weights_size(), get_out_size())) {

Review comment:
       While -> if?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org