You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "Croway (via GitHub)" <gi...@apache.org> on 2023/12/13 13:43:06 UTC

[PR] CAMEL-20231: make generators configurable [camel-spring-boot]

Croway opened a new pull request, #1042:
URL: https://github.com/apache/camel-spring-boot/pull/1042

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-20231: make generators configurable [camel-spring-boot]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #1042:
URL: https://github.com/apache/camel-spring-boot/pull/1042#issuecomment-1854012033

   okay had to do a few small changes - this -starter is somewhat special. It does some weird custom binder stuff, that should not be needed, but do it more normal spring boot way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-20231: make generators configurable [camel-spring-boot]

Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway commented on PR #1042:
URL: https://github.com/apache/camel-spring-boot/pull/1042#issuecomment-1854077246

   oh yeah, makes sense, so that documentation is updated. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-20231: make generators configurable [camel-spring-boot]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #1042:
URL: https://github.com/apache/camel-spring-boot/pull/1042


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-20231: make generators configurable [camel-spring-boot]

Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway commented on PR #1042:
URL: https://github.com/apache/camel-spring-boot/pull/1042#issuecomment-1854015946

   > okay had to do a few small changes - this -starter is somewhat special. It does some weird custom binder stuff, that should not be needed, but do it more normal spring boot way.
   
   Interesting, I am sorry I thought it was an easy change, but doesn't `private String randomIvGeneratorAlgorithm;` resolve to null if not set?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-20231: make generators configurable [camel-spring-boot]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #1042:
URL: https://github.com/apache/camel-spring-boot/pull/1042#issuecomment-1854066102

   yes but isnt there a default algorithm in jasypt itself. And if it has a default then it can also be set in that field, then SB and tooling know what the default value is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org