[GitHub] flink pull request #5512: [FLINK-8677] [flip6] Make ClusterEntrypoint shut d...

[tillrohrmann <gi...@git.apache.org>]

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5512

    [FLINK-8677] [flip6] Make ClusterEntrypoint shut down non-blocking

    ## What is the purpose of the change
    
    Makes the ClusterEntrypoint shut down method non-blocking. This also removes
    the need to run the Dispatcher#terminationFuture callback in the common
    Fork-Join pool.
    
    This PR is based on #5499, #5511 and #5504.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink nonBlockingEntrypointShutdown

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5512.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5512
    
----
commit 51bb532d2490968635214016599475f91c5f97e5
Author: Till Rohrmann <tr...@...>
Date:   2018-02-16T09:08:04Z

    [FLINK-8669] Add completeAll and runAfterwards(Async) to FutureUtils
    
    FutureUtils#completeAll(Collection) takes a collection of futures and returns
    a future which is completed after all of the given futures are completed. This
    also includes exceptional completions. Potentially occurring exceptions are
    recorded and combined into a single exception with which the resulting future
    is completed.
    
    FutureUtils#runAfterwards takes a future and runs a given action after the
    completion of the given future. This also includes an exceptional completion.
    In this case, a potentially occurring exception as the result of the provided
    action will be combined with the future's exception.

commit 25b8893a21c5f3d215bf0bf3dea76ef6a46e612d
Author: Till Rohrmann <tr...@...>
Date:   2018-02-16T17:01:58Z

    [FLINK-8675] Add non-blocking shut down method to RestServerEndpoint
    
    Make shut down method of RestServerEndpoint non blocking.

commit 478c8a2c3d171bd7d02ad73c438a4e571bfbac61
Author: Till Rohrmann <tr...@...>
Date:   2018-02-15T17:43:39Z

    [FLINK-8664] [rest] Change RpcEndpoint#TerminationFuture value type to Void

commit f9907993c85b4a2e4ba33b24d7a498cf80125905
Author: Till Rohrmann <tr...@...>
Date:   2018-02-16T07:12:04Z

    [FLINK-8670] Make MetricRegistryImpl#shutdown non blocking
    
    This commit makes the MetricRegistryImpl#shutdown method non blocking. Instead
    of waiting for the completion of the shutdown procedure, the method returns a
    future which is completed once the metric registry has completed the shut down.

commit 854b9db33eedae958eda6bcf4ed192dcc3970b63
Author: Till Rohrmann <tr...@...>
Date:   2018-02-15T16:58:35Z

    [hotfix] Remove unused method MiniCluster#waitUntilTaskManagerRegistrationsComplete

commit 433eda3df65664048fd575305ece2b4f6425df59
Author: Till Rohrmann <tr...@...>
Date:   2018-02-15T17:14:55Z

    [hotfix] Don't fail LeaderContender and Listener when closing EmbeddedLeaderService

commit e8f0c3eeb8e01dca5a2afb0b75eca61d933a6ab5
Author: Till Rohrmann <tr...@...>
Date:   2018-02-15T17:07:49Z

    [FLINK-8666] [test] Use testDispatcherConfig in MiniCluster
    
    Using the AkkaUtils#testDispatcherConfig reduces the number of started threads.
    This effectively decreases the resource foot print of the MiniCluster.

commit fd686cc8cfbe84c3631fe6a9db0ec386d573f8f8
Author: Till Rohrmann <tr...@...>
Date:   2018-02-15T17:22:21Z

    [hotfix] Fix checkstyle violations in RpcEndpoint

commit ffc65803aa4a86b9f0024c8043a4c5abd46000f2
Author: Till Rohrmann <tr...@...>
Date:   2018-02-15T18:19:48Z

    [FLINK-8665] [rest] Let RpcEndpoint#postStop return completion future
    
    The RpcEndpoint#postStop method returns a CompletableFuture<Void> which is
    completed once all post stop actions have completed. The termination future
    of the respective RpcEndpoint is only completed afterwards.

commit 327e019c7d18a75f861522d275d0e4556dcb0f12
Author: Till Rohrmann <tr...@...>
Date:   2018-02-16T09:08:25Z

    [FLINK-8677] [flip6] Make ClusterEntrypoint shut down non-blocking
    
    Makes the ClusterEntrypoint shut down method non-blocking. This also removes
    the need to run the Dispatcher#terminationFuture callback in the common
    Fork-Join pool.

----


---

[GitHub] flink pull request #5512: [FLINK-8677] [flip6] Make ClusterEntrypoint shut d...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5512


---