You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/04/27 21:21:44 UTC

[GitHub] [incubator-hudi] prashantwason commented on pull request #1520: [HUDI-797] Small performance improvement for rewriting records.

prashantwason commented on pull request #1520:
URL: https://github.com/apache/incubator-hudi/pull/1520#issuecomment-620241928


   HoodieParquetRealtimeInputFormat has hardcoded the positions of the HUDI specific metadata fields.
   
     // These positions have to be deterministic across all tables
     public static final int HOODIE_COMMIT_TIME_COL_POS = 0;
     public static final int HOODIE_RECORD_KEY_COL_POS = 2;
     public static final int HOODIE_PARTITION_PATH_COL_POS = 3;
     public static final String HOODIE_READ_COLUMNS_PROP = "hoodie.read.columns.set";
   
   This is incompatible with the changes required in this PR. Am looking into the reason for the above and whether I can work around it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org