You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by radarwave <gi...@git.apache.org> on 2017/02/07 05:26:26 UTC

[GitHub] incubator-hawq pull request #1107: HAWQ-1316. Fix feature test build on Cent...

GitHub user radarwave opened a pull request:

    https://github.com/apache/incubator-hawq/pull/1107

    HAWQ-1316. Fix feature test build on CentOS7.3

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/radarwave/incubator-hawq rhel7

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/1107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1107
    
----
commit ed9f1663ea27e634cb242581ca0ed97e46c2f0bc
Author: rlei <rl...@pivotal.io>
Date:   2017-02-07T02:46:10Z

    HAWQ-1316. Fix feature test build on CentOS7.3

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1107: HAWQ-1316. Fix feature test build on Cent...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/1107


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1107: HAWQ-1316. Fix feature test build on CentOS7.3

Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1107
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1107: HAWQ-1316. Fix feature test build on Cent...

Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1107#discussion_r99756045
  
    --- Diff: src/test/feature/Makefile ---
    @@ -9,7 +9,7 @@ gmock_lib_path = $(abs_top_srcdir)/depends/thirdparty/googletest/build/googlemoc
     override CXX = g++
     override CXXFLAGS = -Wall -O0 -g -std=c++11
     override CPPFLAGS := -I/usr/include -I/usr/local/include -I/usr/include/libxml2 -I$(abs_top_srcdir)/src/test/feature/ -I$(abs_top_srcdir)/src/test/feature/ManagementTool/ -I$(abs_top_srcdir)/src/test/feature/lib/ -I$(abs_top_srcdir)/src/interfaces/libpq -I$(abs_top_srcdir)/src/interfaces -I$(abs_top_srcdir)/src/include  -I$(gtest_include) -I$(gmock_include)
    -override LIBS := $(LIBS) -lgtest -lpq -lxml2 -ltest
    +override LIBS := $(LIBS) -lgtest -lpq -lxml2 -ltest -l pthread
    --- End diff --
    
    Thanks @paul-guo- , yeah, this place is better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1107: HAWQ-1316. Fix feature test build on CentOS7.3

Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1107
  
    +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1107: HAWQ-1316. Fix feature test build on CentOS7.3

Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1107
  
    +1. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---