You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/10 16:20:58 UTC
[jira] [Commented] (BEAM-1127) JmsIO should create an unique source
in case of topic
[ https://issues.apache.org/jira/browse/BEAM-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15738096#comment-15738096 ]
ASF GitHub Bot commented on BEAM-1127:
--------------------------------------
GitHub user jbonofre opened a pull request:
https://github.com/apache/incubator-beam/pull/1573
[BEAM-1127] Create an unique source when using a JMS topic to avoid p…
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [X] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [X] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [X] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
…otential messages duplication
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbonofre/incubator-beam BEAM-1127
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1573.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1573
----
commit e3a1d73c53a51f1c9ce59c6f3ce2ba5fe6f54f65
Author: Jean-Baptiste Onofré <jb...@apache.org>
Date: 2016-12-10T16:19:44Z
[BEAM-1127] Create an unique source when using a JMS topic to avoid potential messages duplication
----
> JmsIO should create an unique source in case of topic
> -----------------------------------------------------
>
> Key: BEAM-1127
> URL: https://issues.apache.org/jira/browse/BEAM-1127
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-extensions
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
>
> The JmsIO deals with both queue and topic.
> Currently, we create multiple sources depending of the desired number of splits.
> If this behavior is correct when using a queue (we have concurrent consumers of the queue), it's basically wrong when using a topic (we have multiple subscribers, so potentially duplicated message).
> When using a topic, the JmsIO should use an unique source (to avoid messages duplication).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)