You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/06 19:48:33 UTC
[jira] [Commented] (NIFI-3483)
StandardHttpResponseMapperSpec.MergeResponses fails under varying locales
[ https://issues.apache.org/jira/browse/NIFI-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897918#comment-15897918 ]
ASF GitHub Bot commented on NIFI-3483:
--------------------------------------
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/1566
NIFI-3483 - fixed one unit test relying on locale
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-3483
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1566.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1566
----
commit f41385e6a1ae1aebf12d8055660053007b535bd7
Author: Pierre Villard <pi...@gmail.com>
Date: 2017-03-06T19:46:40Z
NIFI-3483 - fixed one unit test relying on locale
----
> StandardHttpResponseMapperSpec.MergeResponses fails under varying locales
> -------------------------------------------------------------------------
>
> Key: NIFI-3483
> URL: https://issues.apache.org/jira/browse/NIFI-3483
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.2.0
> Reporter: Aldrin Piri
> Assignee: Jeff Storck
> Priority: Minor
>
> With the efforts to provide multiple locales for our Travis builds, there seem to be issues with StandardHttpResponseMapperSpec.MergeResponses and possibly others. In this case, differing locales have varying inclusion of commas for numbers.
> A sample Travis build report is available in full at: https://api.travis-ci.org/jobs/201598074/log.txt?deansi=true
> The snippet in question is
> {code}
> Tests run: 15, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.542 sec <<< FAILURE! - in org.apache.nifi.cluster.coordination.http.StandardHttpResponseMapperSpec
> MergeResponses: 3 HTTP 200 get responses for nifi-api/connections/e760637d-1086-44ed-aacf-4f1580182725(org.apache.nifi.cluster.coordination.http.StandardHttpResponseMapperSpec) Time elapsed: 0.177 sec <<< FAILURE!
> org.spockframework.runtime.SpockComparisonFailure: Condition not satisfied:
> returnedJson == expectedJson
> | | |
> | | {"id":"1","permissions":{"canRead":false,"canWrite":false},"status":{"aggregateSnapshot":{"flowFilesIn":0,"bytesIn":1000,"input":"0 (1,000 bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0 bytes)","flowFilesQueued":0,"bytesQueued":0,"queued":"0 (0 bytes)","queuedSize":"0 bytes","queuedCount":"0"}}}
> | false
> | 1 difference (99% similarity)
> | {"id":"1","permissions":{"canRead":false,"canWrite":false},"status":{"aggregateSnapshot":{"flowFilesIn":0,"bytesIn":1000,"input":"0 (1( )000 bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0 bytes)","flowFilesQueued":0,"bytesQueued":0,"queued":"0 (0 bytes)","queuedSize":"0 bytes","queuedCount":"0"}}}
> | {"id":"1","permissions":{"canRead":false,"canWrite":false},"status":{"aggregateSnapshot":{"flowFilesIn":0,"bytesIn":1000,"input":"0 (1(,)000 bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0 bytes)","flowFilesQueued":0,"bytesQueued":0,"queued":"0 (0 bytes)","queuedSize":"0 bytes","queuedCount":"0"}}}
> {"id":"1","permissions":{"canRead":false,"canWrite":false},"status":{"aggregateSnapshot":{"flowFilesIn":0,"bytesIn":1000,"input":"0 (1 000 bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0 bytes)","flowFilesQueued":0,"bytesQueued":0,"queued":"0 (0 bytes)","queuedSize":"0 bytes","queuedCount":"0"}}}
> at org.apache.nifi.cluster.coordination.http.StandardHttpResponseMapperSpec.MergeResponses: #responseEntities.size() HTTP 200 #httpMethod responses for #requestUriPart(StandardHttpResponseMapperSpec.groovy:122)
> Running org.apache.nifi.cluster.coordination.http.endpoints.StatusHistoryEndpointMergerSpec
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.024 sec - in org.apache.nifi.cluster.coordination.http.endpoints.StatusHistoryEndpointMergerSpec
> Running org.apache.nifi.cluster.coordination.http.endpoints.TestProcessorEndpointMerger
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.apache.nifi.cluster.coordination.http.endpoints.TestProcessorEndpointMerger
> Running org.apache.nifi.cluster.coordination.http.endpoints.TestStatusHistoryEndpointMerger
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec - in org.apache.nifi.cluster.coordination.http.endpoints.TestStatusHistoryEndpointMerger
> Running org.apache.nifi.cluster.coordination.node.TestNodeClusterCoordinator
> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.151 sec - in org.apache.nifi.cluster.coordination.node.TestNodeClusterCoordinator
> Running org.apache.nifi.cluster.coordination.heartbeat.TestAbstractHeartbeatMonitor
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.057 sec - in org.apache.nifi.cluster.coordination.heartbeat.TestAbstractHeartbeatMonitor
> Running org.apache.nifi.cluster.coordination.flow.TestPopularVoteFlowElection
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.347 sec - in org.apache.nifi.cluster.coordination.flow.TestPopularVoteFlowElection
> Running org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.095 sec - in org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest
> Results :
> Failed tests:
> StandardHttpResponseMapperSpec.MergeResponses: #responseEntities.size() HTTP 200 #httpMethod responses for #requestUriPart:122 Condition not satisfied:
> returnedJson == expectedJson
> | | |
> | | {"id":"1","permissions":{"canRead":false,"canWrite":false},"status":{"aggregateSnapshot":{"flowFilesIn":0,"bytesIn":1000,"input":"0 (1,000 bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0 bytes)","flowFilesQueued":0,"bytesQueued":0,"queued":"0 (0 bytes)","queuedSize":"0 bytes","queuedCount":"0"}}}
> | false
> | 1 difference (99% similarity)
> | {"id":"1","permissions":{"canRead":false,"canWrite":false},"status":{"aggregateSnapshot":{"flowFilesIn":0,"bytesIn":1000,"input":"0 (1( )000 bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0 bytes)","flowFilesQueued":0,"bytesQueued":0,"queued":"0 (0 bytes)","queuedSize":"0 bytes","queuedCount":"0"}}}
> | {"id":"1","permissions":{"canRead":false,"canWrite":false},"status":{"aggregateSnapshot":{"flowFilesIn":0,"bytesIn":1000,"input":"0 (1(,)000 bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0 bytes)","flowFilesQueued":0,"bytesQueued":0,"queued":"0 (0 bytes)","queuedSize":"0 bytes","queuedCount":"0"}}}
> {"id":"1","permissions":{"canRead":false,"canWrite":false},"status":{"aggregateSnapshot":{"flowFilesIn":0,"bytesIn":1000,"input":"0 (1 000 bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0 bytes)","flowFilesQueued":0,"bytesQueued":0,"queued":"0 (0 bytes)","queuedSize":"0 bytes","queuedCount":"0"}}}
> Tests run: 78, Failures: 1, Errors: 0, Skipped: 0
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)